net: Validate xmit SKBs right when we pull them out of the qdisc.
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
eae3f88ee4
commit
50cbe9ab5f
|
@ -2827,6 +2827,7 @@ int dev_set_mac_address(struct net_device *, struct sockaddr *);
|
|||
int dev_change_carrier(struct net_device *, bool new_carrier);
|
||||
int dev_get_phys_port_id(struct net_device *dev,
|
||||
struct netdev_phys_port_id *ppid);
|
||||
struct sk_buff *validate_xmit_skb(struct sk_buff *skb, struct net_device *dev);
|
||||
int dev_hard_start_xmit(struct sk_buff *skb, struct net_device *dev,
|
||||
struct netdev_queue *txq);
|
||||
int __dev_forward_skb(struct net_device *dev, struct sk_buff *skb);
|
||||
|
|
|
@ -2656,7 +2656,7 @@ struct sk_buff *validate_xmit_vlan(struct sk_buff *skb, netdev_features_t featur
|
|||
return skb;
|
||||
}
|
||||
|
||||
static struct sk_buff *validate_xmit_skb(struct sk_buff *skb, struct net_device *dev)
|
||||
struct sk_buff *validate_xmit_skb(struct sk_buff *skb, struct net_device *dev)
|
||||
{
|
||||
netdev_features_t features;
|
||||
|
||||
|
@ -2719,10 +2719,6 @@ int dev_hard_start_xmit(struct sk_buff *skb, struct net_device *dev,
|
|||
{
|
||||
int rc = NETDEV_TX_OK;
|
||||
|
||||
skb = validate_xmit_skb(skb, dev);
|
||||
if (!skb)
|
||||
return rc;
|
||||
|
||||
if (likely(!skb->next))
|
||||
return xmit_one(skb, dev, txq, false);
|
||||
|
||||
|
|
|
@ -70,8 +70,11 @@ static inline struct sk_buff *dequeue_skb(struct Qdisc *q)
|
|||
} else
|
||||
skb = NULL;
|
||||
} else {
|
||||
if (!(q->flags & TCQ_F_ONETXQUEUE) || !netif_xmit_frozen_or_stopped(txq))
|
||||
if (!(q->flags & TCQ_F_ONETXQUEUE) || !netif_xmit_frozen_or_stopped(txq)) {
|
||||
skb = q->dequeue(q);
|
||||
if (skb)
|
||||
skb = validate_xmit_skb(skb, qdisc_dev(q));
|
||||
}
|
||||
}
|
||||
|
||||
return skb;
|
||||
|
|
Loading…
Reference in New Issue