virtio_net: minor cleanup
goto done; done: return; is ugly, it was put there to make diff review easier. replace by open-coded return. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
parent
080c637373
commit
507613bf31
|
@ -1403,7 +1403,7 @@ static void virtnet_config_changed_work(struct work_struct *work)
|
||||||
|
|
||||||
if (virtio_cread_feature(vi->vdev, VIRTIO_NET_F_STATUS,
|
if (virtio_cread_feature(vi->vdev, VIRTIO_NET_F_STATUS,
|
||||||
struct virtio_net_config, status, &v) < 0)
|
struct virtio_net_config, status, &v) < 0)
|
||||||
goto done;
|
return;
|
||||||
|
|
||||||
if (v & VIRTIO_NET_S_ANNOUNCE) {
|
if (v & VIRTIO_NET_S_ANNOUNCE) {
|
||||||
netdev_notify_peers(vi->dev);
|
netdev_notify_peers(vi->dev);
|
||||||
|
@ -1414,7 +1414,7 @@ static void virtnet_config_changed_work(struct work_struct *work)
|
||||||
v &= VIRTIO_NET_S_LINK_UP;
|
v &= VIRTIO_NET_S_LINK_UP;
|
||||||
|
|
||||||
if (vi->status == v)
|
if (vi->status == v)
|
||||||
goto done;
|
return;
|
||||||
|
|
||||||
vi->status = v;
|
vi->status = v;
|
||||||
|
|
||||||
|
@ -1425,8 +1425,6 @@ static void virtnet_config_changed_work(struct work_struct *work)
|
||||||
netif_carrier_off(vi->dev);
|
netif_carrier_off(vi->dev);
|
||||||
netif_tx_stop_all_queues(vi->dev);
|
netif_tx_stop_all_queues(vi->dev);
|
||||||
}
|
}
|
||||||
done:
|
|
||||||
return;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
static void virtnet_config_changed(struct virtio_device *vdev)
|
static void virtnet_config_changed(struct virtio_device *vdev)
|
||||||
|
|
Loading…
Reference in New Issue