spi: spi_s3c24xx driver must init completion
The s3c24xx_spi_txrx() function should initialise the completion each time before using it, otherwise we end up with the possibility of returning success before the interrupt handler has processed all the data. Signed-off-by: Ben Dooks <ben-linux@fluff.org> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
parent
335e92e8a5
commit
4bb5eba06b
|
@ -192,8 +192,11 @@ static int s3c24xx_spi_txrx(struct spi_device *spi, struct spi_transfer *t)
|
|||
hw->len = t->len;
|
||||
hw->count = 0;
|
||||
|
||||
init_completion(&hw->done);
|
||||
|
||||
/* send the first byte */
|
||||
writeb(hw_txbyte(hw, 0), hw->regs + S3C2410_SPTDAT);
|
||||
|
||||
wait_for_completion(&hw->done);
|
||||
|
||||
return hw->count;
|
||||
|
|
Loading…
Reference in New Issue