net/smc: Limit SMC visits when handshake workqueue congested
This patch intends to provide a mechanism to put constraint on SMC connections visit according to the pressure of SMC handshake process. At present, frequent visits will cause the incoming connections to be backlogged in SMC handshake queue, raise the connections established time. Which is quite unacceptable for those applications who base on short lived connections. There are two ways to implement this mechanism: 1. Put limitation after TCP established. 2. Put limitation before TCP established. In the first way, we need to wait and receive CLC messages that the client will potentially send, and then actively reply with a decline message, in a sense, which is also a sort of SMC handshake, affect the connections established time on its way. In the second way, the only problem is that we need to inject SMC logic into TCP when it is about to reply the incoming SYN, since we already do that, it's seems not a problem anymore. And advantage is obvious, few additional processes are required to complete the constraint. This patch use the second way. After this patch, connections who beyond constraint will not informed any SMC indication, and SMC will not be involved in any of its subsequent processes. Link: https://lore.kernel.org/all/1641301961-59331-1-git-send-email-alibuda@linux.alibaba.com/ Signed-off-by: D. Wythe <alibuda@linux.alibaba.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
8270d9c210
commit
48b6190a00
|
@ -394,6 +394,7 @@ struct tcp_sock {
|
|||
bool is_mptcp;
|
||||
#endif
|
||||
#if IS_ENABLED(CONFIG_SMC)
|
||||
bool (*smc_hs_congested)(const struct sock *sk);
|
||||
bool syn_smc; /* SYN includes SMC */
|
||||
#endif
|
||||
|
||||
|
|
|
@ -6703,7 +6703,8 @@ static void tcp_openreq_init(struct request_sock *req,
|
|||
ireq->ir_num = ntohs(tcp_hdr(skb)->dest);
|
||||
ireq->ir_mark = inet_request_mark(sk, skb);
|
||||
#if IS_ENABLED(CONFIG_SMC)
|
||||
ireq->smc_ok = rx_opt->smc_ok;
|
||||
ireq->smc_ok = rx_opt->smc_ok && !(tcp_sk(sk)->smc_hs_congested &&
|
||||
tcp_sk(sk)->smc_hs_congested(sk));
|
||||
#endif
|
||||
}
|
||||
|
||||
|
|
|
@ -103,6 +103,21 @@ drop:
|
|||
return NULL;
|
||||
}
|
||||
|
||||
static bool smc_hs_congested(const struct sock *sk)
|
||||
{
|
||||
const struct smc_sock *smc;
|
||||
|
||||
smc = smc_clcsock_user_data(sk);
|
||||
|
||||
if (!smc)
|
||||
return true;
|
||||
|
||||
if (workqueue_congested(WORK_CPU_UNBOUND, smc_hs_wq))
|
||||
return true;
|
||||
|
||||
return false;
|
||||
}
|
||||
|
||||
static struct smc_hashinfo smc_v4_hashinfo = {
|
||||
.lock = __RW_LOCK_UNLOCKED(smc_v4_hashinfo.lock),
|
||||
};
|
||||
|
@ -2311,6 +2326,8 @@ static int smc_listen(struct socket *sock, int backlog)
|
|||
|
||||
inet_csk(smc->clcsock->sk)->icsk_af_ops = &smc->af_ops;
|
||||
|
||||
tcp_sk(smc->clcsock->sk)->smc_hs_congested = smc_hs_congested;
|
||||
|
||||
rc = kernel_listen(smc->clcsock, backlog);
|
||||
if (rc) {
|
||||
smc->clcsock->sk->sk_data_ready = smc->clcsk_data_ready;
|
||||
|
|
Loading…
Reference in New Issue