OMAP: control: move plat-omap/control.h to mach-omap2/control.h

Only OMAP2+ platforms have the System Control Module (SCM) IP block.
In the past, we've kept the SCM header file in plat-omap.  This has
led to abuse - device drivers including it; includes being added that
create implicit dependencies on OMAP2+ builds; etc.

In response, move the SCM headers into mach-omap2/.

As part of this, remove the direct SCM access from the OMAP UDC
driver.  It was clearly broken.  The UDC code needs an indepth review for
use on OMAP2+ chips.

Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Cory Maccarrone <darkstar6262@gmail.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
This commit is contained in:
Paul Walmsley 2010-10-08 11:40:20 -06:00
parent aa218dafd7
commit 4814ced511
31 changed files with 48 additions and 59 deletions

View File

@ -39,7 +39,6 @@
#include <plat/gpmc.h> #include <plat/gpmc.h>
#include <plat/display.h> #include <plat/display.h>
#include <plat/control.h>
#include <plat/gpmc-smc91x.h> #include <plat/gpmc-smc91x.h>
#include "board-flash.h" #include "board-flash.h"
@ -47,6 +46,7 @@
#include "sdram-qimonda-hyb18m512160af-6.h" #include "sdram-qimonda-hyb18m512160af-6.h"
#include "hsmmc.h" #include "hsmmc.h"
#include "pm.h" #include "pm.h"
#include "control.h"
#define CONFIG_DISABLE_HFCLK 1 #define CONFIG_DISABLE_HFCLK 1

View File

@ -32,12 +32,12 @@
#include <plat/board.h> #include <plat/board.h>
#include <plat/common.h> #include <plat/common.h>
#include <plat/control.h>
#include <plat/usb.h> #include <plat/usb.h>
#include <plat/mmc.h> #include <plat/mmc.h>
#include "hsmmc.h" #include "hsmmc.h"
#include "timer-gp.h" #include "timer-gp.h"
#include "control.h"
#define ETH_KS8851_IRQ 34 #define ETH_KS8851_IRQ 34
#define ETH_KS8851_POWER_ON 48 #define ETH_KS8851_POWER_ON 48

View File

@ -32,11 +32,11 @@
#include <plat/board.h> #include <plat/board.h>
#include <plat/common.h> #include <plat/common.h>
#include <plat/control.h>
#include <plat/usb.h> #include <plat/usb.h>
#include <plat/display.h> #include <plat/display.h>
#include "mux.h" #include "mux.h"
#include "control.h"
#define AM35XX_EVM_PHY_MASK (0xF) #define AM35XX_EVM_PHY_MASK (0xF)
#define AM35XX_EVM_MDIO_FREQUENCY (1000000) #define AM35XX_EVM_MDIO_FREQUENCY (1000000)

View File

@ -39,9 +39,9 @@
#include <plat/board.h> #include <plat/board.h>
#include <plat/common.h> #include <plat/common.h>
#include <plat/gpmc.h> #include <plat/gpmc.h>
#include <plat/control.h>
#include "mux.h" #include "mux.h"
#include "control.h"
/* LED & Switch macros */ /* LED & Switch macros */
#define LED0_GPIO13 13 #define LED0_GPIO13 13

View File

@ -40,7 +40,6 @@
#include <plat/board.h> #include <plat/board.h>
#include <plat/common.h> #include <plat/common.h>
#include <plat/control.h>
#include <plat/usb.h> #include <plat/usb.h>
#include <plat/nand.h> #include <plat/nand.h>
#include <plat/gpmc.h> #include <plat/gpmc.h>
@ -48,6 +47,7 @@
#include <mach/am35xx.h> #include <mach/am35xx.h>
#include "mux.h" #include "mux.h"
#include "control.h"
#if defined(CONFIG_LEDS_GPIO) || defined(CONFIG_LEDS_GPIO_MODULE) #if defined(CONFIG_LEDS_GPIO) || defined(CONFIG_LEDS_GPIO_MODULE)
static struct gpio_led cm_t3517_leds[] = { static struct gpio_led cm_t3517_leds[] = {

View File

@ -31,7 +31,6 @@
#include <asm/mach/arch.h> #include <asm/mach/arch.h>
#include <asm/mach/map.h> #include <asm/mach/map.h>
#include <plat/control.h>
#include <mach/gpio.h> #include <mach/gpio.h>
#include <plat/usb.h> #include <plat/usb.h>
#include <plat/board.h> #include <plat/board.h>
@ -42,6 +41,7 @@
#include <plat/gpmc.h> #include <plat/gpmc.h>
#include "mux.h" #include "mux.h"
#include "control.h"
#define H4_FLASH_CS 0 #define H4_FLASH_CS 0
#define H4_SMC91X_CS 1 #define H4_SMC91X_CS 1

View File

@ -42,12 +42,12 @@
#include <mach/board-zoom.h> #include <mach/board-zoom.h>
#include <asm/delay.h> #include <asm/delay.h>
#include <plat/control.h>
#include <plat/usb.h> #include <plat/usb.h>
#include "board-flash.h" #include "board-flash.h"
#include "mux.h" #include "mux.h"
#include "hsmmc.h" #include "hsmmc.h"
#include "control.h"
#define LDP_SMSC911X_CS 1 #define LDP_SMSC911X_CS 1
#define LDP_SMSC911X_GPIO 152 #define LDP_SMSC911X_GPIO 152

View File

@ -36,6 +36,7 @@
#include "mux.h" #include "mux.h"
#include "hsmmc.h" #include "hsmmc.h"
#include "timer-gp.h" #include "timer-gp.h"
#include "control.h"
#include <plat/mux.h> #include <plat/mux.h>
#include <plat/board.h> #include <plat/board.h>
@ -43,7 +44,6 @@
#include <plat/gpmc-smsc911x.h> #include <plat/gpmc-smsc911x.h>
#include <plat/gpmc.h> #include <plat/gpmc.h>
#include <plat/sdrc.h> #include <plat/sdrc.h>
#include <plat/control.h>
#define OMAP3LOGIC_SMSC911X_CS 1 #define OMAP3LOGIC_SMSC911X_CS 1

View File

@ -34,12 +34,12 @@
#include <plat/board.h> #include <plat/board.h>
#include <plat/common.h> #include <plat/common.h>
#include <plat/control.h>
#include <plat/usb.h> #include <plat/usb.h>
#include <plat/mmc.h> #include <plat/mmc.h>
#include "hsmmc.h"
#include "timer-gp.h" #include "timer-gp.h"
#include "hsmmc.h"
#include "control.h"
static struct gpio_led gpio_leds[] = { static struct gpio_led gpio_leds[] = {
{ {

View File

@ -18,7 +18,6 @@
#include <linux/list.h> #include <linux/list.h>
#include <plat/clkdev_omap.h> #include <plat/clkdev_omap.h>
#include <plat/control.h>
#include "clock.h" #include "clock.h"
#include "clock2xxx.h" #include "clock2xxx.h"
@ -28,6 +27,7 @@
#include "prm-regbits-24xx.h" #include "prm-regbits-24xx.h"
#include "cm-regbits-24xx.h" #include "cm-regbits-24xx.h"
#include "sdrc.h" #include "sdrc.h"
#include "control.h"
#define OMAP_CM_REGADDR OMAP2420_CM_REGADDR #define OMAP_CM_REGADDR OMAP2420_CM_REGADDR

View File

@ -18,7 +18,6 @@
#include <linux/list.h> #include <linux/list.h>
#include <plat/clkdev_omap.h> #include <plat/clkdev_omap.h>
#include <plat/control.h>
#include "clock.h" #include "clock.h"
#include "clock2xxx.h" #include "clock2xxx.h"
@ -28,6 +27,7 @@
#include "prm-regbits-24xx.h" #include "prm-regbits-24xx.h"
#include "cm-regbits-24xx.h" #include "cm-regbits-24xx.h"
#include "sdrc.h" #include "sdrc.h"
#include "control.h"
#define OMAP_CM_REGADDR OMAP2430_CM_REGADDR #define OMAP_CM_REGADDR OMAP2430_CM_REGADDR

View File

@ -20,7 +20,6 @@
#include <linux/clk.h> #include <linux/clk.h>
#include <linux/list.h> #include <linux/list.h>
#include <plat/control.h>
#include <plat/clkdev_omap.h> #include <plat/clkdev_omap.h>
#include "clock.h" #include "clock.h"
@ -33,6 +32,7 @@
#include "cm-regbits-34xx.h" #include "cm-regbits-34xx.h"
#include "prm.h" #include "prm.h"
#include "prm-regbits-34xx.h" #include "prm-regbits-34xx.h"
#include "control.h"
/* /*
* clocks * clocks

View File

@ -26,7 +26,6 @@
#include <linux/kernel.h> #include <linux/kernel.h>
#include <linux/list.h> #include <linux/list.h>
#include <linux/clk.h> #include <linux/clk.h>
#include <plat/control.h>
#include <plat/clkdev_omap.h> #include <plat/clkdev_omap.h>
#include "clock.h" #include "clock.h"
@ -35,6 +34,7 @@
#include "cm-regbits-44xx.h" #include "cm-regbits-44xx.h"
#include "prm.h" #include "prm.h"
#include "prm-regbits-44xx.h" #include "prm-regbits-44xx.h"
#include "control.h"
/* Root clocks */ /* Root clocks */

View File

@ -19,12 +19,12 @@
#include <plat/common.h> #include <plat/common.h>
#include <plat/board.h> #include <plat/board.h>
#include <plat/control.h>
#include <plat/mux.h> #include <plat/mux.h>
#include <plat/clock.h> #include <plat/clock.h>
#include "sdrc.h" #include "sdrc.h"
#include "control.h"
/* Global address base setup code */ /* Global address base setup code */

View File

@ -16,14 +16,15 @@
#include <linux/io.h> #include <linux/io.h>
#include <plat/common.h> #include <plat/common.h>
#include <plat/control.h>
#include <plat/sdrc.h> #include <plat/sdrc.h>
#include "cm-regbits-34xx.h" #include "cm-regbits-34xx.h"
#include "prm-regbits-34xx.h" #include "prm-regbits-34xx.h"
#include "cm.h" #include "cm.h"
#include "prm.h" #include "prm.h"
#include "sdrc.h" #include "sdrc.h"
#include "pm.h" #include "pm.h"
#include "control.h"
static void __iomem *omap2_ctrl_base; static void __iomem *omap2_ctrl_base;
static void __iomem *omap4_ctrl_pad_base; static void __iomem *omap4_ctrl_pad_base;

View File

@ -1,10 +1,10 @@
/* /*
* arch/arm/plat-omap/include/mach/control.h * arch/arm/mach-omap2/control.h
* *
* OMAP2/3/4 System Control Module definitions * OMAP2/3/4 System Control Module definitions
* *
* Copyright (C) 2007-2009 Texas Instruments, Inc. * Copyright (C) 2007-2010 Texas Instruments, Inc.
* Copyright (C) 2007-2008 Nokia Corporation * Copyright (C) 2007-2008, 2010 Nokia Corporation
* *
* Written by Paul Walmsley * Written by Paul Walmsley
* *
@ -13,8 +13,8 @@
* the Free Software Foundation. * the Free Software Foundation.
*/ */
#ifndef __ASM_ARCH_CONTROL_H #ifndef __ARCH_ARM_MACH_OMAP2_CONTROL_H
#define __ASM_ARCH_CONTROL_H #define __ARCH_ARM_MACH_OMAP2_CONTROL_H
#include <mach/io.h> #include <mach/io.h>
#include <mach/ctrl_module_core_44xx.h> #include <mach/ctrl_module_core_44xx.h>
@ -321,12 +321,12 @@
#define FEAT_L2CACHE_256KB 3 #define FEAT_L2CACHE_256KB 3
#define OMAP3_ISP_SHIFT 5 #define OMAP3_ISP_SHIFT 5
#define OMAP3_ISP_MASK (1<< OMAP3_ISP_SHIFT) #define OMAP3_ISP_MASK (1 << OMAP3_ISP_SHIFT)
#define FEAT_ISP 0 #define FEAT_ISP 0
#define FEAT_ISP_NONE 1 #define FEAT_ISP_NONE 1
#define OMAP3_NEON_SHIFT 4 #define OMAP3_NEON_SHIFT 4
#define OMAP3_NEON_MASK (1<< OMAP3_NEON_SHIFT) #define OMAP3_NEON_MASK (1 << OMAP3_NEON_SHIFT)
#define FEAT_NEON 0 #define FEAT_NEON 0
#define FEAT_NEON_NONE 1 #define FEAT_NEON_NONE 1
@ -364,5 +364,5 @@ extern void omap3_control_restore_context(void);
#endif #endif
#endif /* __ASSEMBLY__ */ #endif /* __ASSEMBLY__ */
#endif /* __ASM_ARCH_CONTROL_H */ #endif /* __ARCH_ARM_MACH_OMAP2_CONTROL_H */

View File

@ -29,10 +29,10 @@
#include <plat/irqs.h> #include <plat/irqs.h>
#include <plat/powerdomain.h> #include <plat/powerdomain.h>
#include <plat/clockdomain.h> #include <plat/clockdomain.h>
#include <plat/control.h>
#include <plat/serial.h> #include <plat/serial.h>
#include "pm.h" #include "pm.h"
#include "control.h"
#ifdef CONFIG_CPU_IDLE #ifdef CONFIG_CPU_IDLE

View File

@ -9,7 +9,6 @@
* (at your option) any later version. * (at your option) any later version.
*/ */
#include <linux/module.h>
#include <linux/kernel.h> #include <linux/kernel.h>
#include <linux/init.h> #include <linux/init.h>
#include <linux/platform_device.h> #include <linux/platform_device.h>
@ -23,7 +22,6 @@
#include <asm/mach/map.h> #include <asm/mach/map.h>
#include <asm/pmu.h> #include <asm/pmu.h>
#include <plat/control.h>
#include <plat/tc.h> #include <plat/tc.h>
#include <plat/board.h> #include <plat/board.h>
#include <mach/gpio.h> #include <mach/gpio.h>
@ -33,6 +31,7 @@
#include <plat/omap_device.h> #include <plat/omap_device.h>
#include "mux.h" #include "mux.h"
#include "control.h"
#if defined(CONFIG_VIDEO_OMAP2) || defined(CONFIG_VIDEO_OMAP2_MODULE) #if defined(CONFIG_VIDEO_OMAP2) || defined(CONFIG_VIDEO_OMAP2_MODULE)

View File

@ -14,11 +14,11 @@
#include <linux/string.h> #include <linux/string.h>
#include <linux/delay.h> #include <linux/delay.h>
#include <mach/hardware.h> #include <mach/hardware.h>
#include <plat/control.h>
#include <plat/mmc.h> #include <plat/mmc.h>
#include <plat/omap-pm.h> #include <plat/omap-pm.h>
#include "hsmmc.h" #include "hsmmc.h"
#include "control.h"
#if defined(CONFIG_MMC_OMAP_HS) || defined(CONFIG_MMC_OMAP_HS_MODULE) #if defined(CONFIG_MMC_OMAP_HS) || defined(CONFIG_MMC_OMAP_HS_MODULE)

View File

@ -22,11 +22,12 @@
#include <asm/cputype.h> #include <asm/cputype.h>
#include <plat/common.h> #include <plat/common.h>
#include <plat/control.h>
#include <plat/cpu.h> #include <plat/cpu.h>
#include <mach/id.h> #include <mach/id.h>
#include "control.h"
static struct omap_chip_id omap_chip; static struct omap_chip_id omap_chip;
static unsigned int omap_revision; static unsigned int omap_revision;

View File

@ -22,7 +22,9 @@
#include <plat/dma.h> #include <plat/dma.h>
#include <plat/cpu.h> #include <plat/cpu.h>
#include <plat/mcbsp.h> #include <plat/mcbsp.h>
#include <plat/control.h>
#include "control.h"
/* McBSP internal signal muxing functions */ /* McBSP internal signal muxing functions */

View File

@ -23,12 +23,11 @@
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
* *
*/ */
#include <linux/module.h> #include <linux/kernel.h>
#include <linux/init.h> #include <linux/init.h>
#include <linux/io.h> #include <linux/io.h>
#include <linux/slab.h>
#include <linux/spinlock.h>
#include <linux/list.h> #include <linux/list.h>
#include <linux/slab.h>
#include <linux/ctype.h> #include <linux/ctype.h>
#include <linux/debugfs.h> #include <linux/debugfs.h>
#include <linux/seq_file.h> #include <linux/seq_file.h>
@ -36,8 +35,7 @@
#include <asm/system.h> #include <asm/system.h>
#include <plat/control.h> #include "control.h"
#include "mux.h" #include "mux.h"
#define OMAP_MUX_BASE_OFFSET 0x30 /* Offset from CTRL_BASE */ #define OMAP_MUX_BASE_OFFSET 0x30 /* Offset from CTRL_BASE */

View File

@ -38,7 +38,6 @@
#include <mach/irqs.h> #include <mach/irqs.h>
#include <plat/clock.h> #include <plat/clock.h>
#include <plat/sram.h> #include <plat/sram.h>
#include <plat/control.h>
#include <plat/dma.h> #include <plat/dma.h>
#include <plat/board.h> #include <plat/board.h>
@ -48,6 +47,7 @@
#include "cm-regbits-24xx.h" #include "cm-regbits-24xx.h"
#include "sdrc.h" #include "sdrc.h"
#include "pm.h" #include "pm.h"
#include "control.h"
#include <plat/powerdomain.h> #include <plat/powerdomain.h>
#include <plat/clockdomain.h> #include <plat/clockdomain.h>

View File

@ -32,7 +32,6 @@
#include <plat/sram.h> #include <plat/sram.h>
#include <plat/clockdomain.h> #include <plat/clockdomain.h>
#include <plat/powerdomain.h> #include <plat/powerdomain.h>
#include <plat/control.h>
#include <plat/serial.h> #include <plat/serial.h>
#include <plat/sdrc.h> #include <plat/sdrc.h>
#include <plat/prcm.h> #include <plat/prcm.h>
@ -48,6 +47,7 @@
#include "prm.h" #include "prm.h"
#include "pm.h" #include "pm.h"
#include "sdrc.h" #include "sdrc.h"
#include "control.h"
/* Scratchpad offsets */ /* Scratchpad offsets */
#define OMAP343X_TABLE_ADDRESS_OFFSET 0x31 #define OMAP343X_TABLE_ADDRESS_OFFSET 0x31

View File

@ -26,7 +26,6 @@
#include <plat/common.h> #include <plat/common.h>
#include <plat/prcm.h> #include <plat/prcm.h>
#include <plat/irqs.h> #include <plat/irqs.h>
#include <plat/control.h>
#include "clock.h" #include "clock.h"
#include "clock2xxx.h" #include "clock2xxx.h"
@ -34,6 +33,7 @@
#include "prm.h" #include "prm.h"
#include "prm-regbits-24xx.h" #include "prm-regbits-24xx.h"
#include "prm-regbits-44xx.h" #include "prm-regbits-44xx.h"
#include "control.h"
static void __iomem *prm_base; static void __iomem *prm_base;
static void __iomem *cm_base; static void __iomem *cm_base;

View File

@ -35,7 +35,6 @@
#include <plat/common.h> #include <plat/common.h>
#include <plat/board.h> #include <plat/board.h>
#include <plat/clock.h> #include <plat/clock.h>
#include <plat/control.h>
#include <plat/dma.h> #include <plat/dma.h>
#include <plat/omap_hwmod.h> #include <plat/omap_hwmod.h>
#include <plat/omap_device.h> #include <plat/omap_device.h>
@ -44,6 +43,7 @@
#include "pm.h" #include "pm.h"
#include "cm.h" #include "cm.h"
#include "prm-regbits-34xx.h" #include "prm-regbits-34xx.h"
#include "control.h"
#define UART_OMAP_NO_EMPTY_FIFO_READ_IP_REV 0x52 #define UART_OMAP_NO_EMPTY_FIFO_READ_IP_REV 0x52
#define UART_OMAP_WER 0x17 /* Wake-up enable register */ #define UART_OMAP_WER 0x17 /* Wake-up enable register */

View File

@ -27,11 +27,11 @@
#include <linux/linkage.h> #include <linux/linkage.h>
#include <asm/assembler.h> #include <asm/assembler.h>
#include <mach/io.h> #include <mach/io.h>
#include <plat/control.h>
#include "cm.h" #include "cm.h"
#include "prm.h" #include "prm.h"
#include "sdrc.h" #include "sdrc.h"
#include "control.h"
#define SDRC_SCRATCHPAD_SEM_V 0xfa00291c #define SDRC_SCRATCHPAD_SEM_V 0xfa00291c

View File

@ -29,18 +29,18 @@
#include <asm/irq.h> #include <asm/irq.h>
#include <plat/control.h>
#include <plat/usb.h> #include <plat/usb.h>
#include <plat/board.h> #include <plat/board.h>
#include "control.h"
#include "mux.h"
#define INT_USB_IRQ_GEN INT_24XX_USB_IRQ_GEN #define INT_USB_IRQ_GEN INT_24XX_USB_IRQ_GEN
#define INT_USB_IRQ_NISO INT_24XX_USB_IRQ_NISO #define INT_USB_IRQ_NISO INT_24XX_USB_IRQ_NISO
#define INT_USB_IRQ_ISO INT_24XX_USB_IRQ_ISO #define INT_USB_IRQ_ISO INT_24XX_USB_IRQ_ISO
#define INT_USB_IRQ_HGEN INT_24XX_USB_IRQ_HGEN #define INT_USB_IRQ_HGEN INT_24XX_USB_IRQ_HGEN
#define INT_USB_IRQ_OTG INT_24XX_USB_IRQ_OTG #define INT_USB_IRQ_OTG INT_24XX_USB_IRQ_OTG
#include "mux.h"
#if defined(CONFIG_ARCH_OMAP2) #if defined(CONFIG_ARCH_OMAP2)
#ifdef CONFIG_USB_GADGET_OMAP #ifdef CONFIG_USB_GADGET_OMAP

View File

@ -20,7 +20,6 @@
#include <linux/serial_core.h> #include <linux/serial_core.h>
#include <linux/platform_device.h> #include <linux/platform_device.h>
#include <plat/control.h>
#include <plat/mux.h> #include <plat/mux.h>
#define DRIVER_NAME "omap-hsuart" #define DRIVER_NAME "omap-hsuart"

View File

@ -27,7 +27,6 @@
#include <plat/dma.h> #include <plat/dma.h>
#include <plat/mcbsp.h> #include <plat/mcbsp.h>
#include <plat/control.h>
#include "../mach-omap2/cm-regbits-34xx.h" #include "../mach-omap2/cm-regbits-34xx.h"

View File

@ -54,7 +54,6 @@
#include <plat/dma.h> #include <plat/dma.h>
#include <plat/usb.h> #include <plat/usb.h>
#include <plat/control.h>
#include "omap_udc.h" #include "omap_udc.h"
@ -2309,21 +2308,12 @@ static char *trx_mode(unsigned m, int enabled)
static int proc_otg_show(struct seq_file *s) static int proc_otg_show(struct seq_file *s)
{ {
u32 tmp; u32 tmp;
u32 trans; u32 trans = 0;
char *ctrl_name; char *ctrl_name = "(UNKNOWN)";
/* XXX This needs major revision for OMAP2+ */
tmp = omap_readl(OTG_REV); tmp = omap_readl(OTG_REV);
if (cpu_is_omap24xx()) { if (cpu_class_is_omap1()) {
/*
* REVISIT: Not clear how this works on OMAP2. trans
* is ANDed to produce bits 7 and 8, which might make
* sense for USB_TRANSCEIVER_CTRL on OMAP1,
* but with CONTROL_DEVCONF, these bits have something to
* do with the frame adjustment counter and McBSP2.
*/
ctrl_name = "control_devconf";
trans = omap_ctrl_readl(OMAP2_CONTROL_DEVCONF0);
} else {
ctrl_name = "tranceiver_ctrl"; ctrl_name = "tranceiver_ctrl";
trans = omap_readw(USB_TRANSCEIVER_CTRL); trans = omap_readw(USB_TRANSCEIVER_CTRL);
} }