cdc_ncm: Fix tx_bytes statistics
The tx_curr_frame_payload field is u32. When we try to calculate a
small negative delta based on it, we end up with a positive integer
close to 2^32 instead. So the tx_bytes pointer increases by about
2^32 for every transmitted frame.
Fix by calculating the delta as a signed long.
Cc: Ben Hutchings <ben.hutchings@codethink.co.uk>
Reported-by: Florian Bruhin <me@the-compiler.org>
Fixes: 7a1e890e21
("usbnet: Fix tx_bytes statistic running backward in cdc_ncm")
Signed-off-by: Bjørn Mork <bjorn@mork.no>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
572152adfb
commit
44f6731d8b
|
@ -1182,7 +1182,7 @@ cdc_ncm_fill_tx_frame(struct usbnet *dev, struct sk_buff *skb, __le32 sign)
|
||||||
* payload data instead.
|
* payload data instead.
|
||||||
*/
|
*/
|
||||||
usbnet_set_skb_tx_stats(skb_out, n,
|
usbnet_set_skb_tx_stats(skb_out, n,
|
||||||
ctx->tx_curr_frame_payload - skb_out->len);
|
(long)ctx->tx_curr_frame_payload - skb_out->len);
|
||||||
|
|
||||||
return skb_out;
|
return skb_out;
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue