ocfs2: one function call less in user_cluster_connect() after error detection
kfree() was called by user_cluster_connect() even if a previous call of the kzalloc() function failed. Return from this implementation directly after failure detection. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Cc: Mark Fasheh <mfasheh@suse.com> Cc: Joel Becker <jlbec@evilplan.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
parent
bb34ed21bc
commit
43ee9cad8a
|
@ -1004,10 +1004,8 @@ static int user_cluster_connect(struct ocfs2_cluster_connection *conn)
|
||||||
BUG_ON(conn == NULL);
|
BUG_ON(conn == NULL);
|
||||||
|
|
||||||
lc = kzalloc(sizeof(struct ocfs2_live_connection), GFP_KERNEL);
|
lc = kzalloc(sizeof(struct ocfs2_live_connection), GFP_KERNEL);
|
||||||
if (!lc) {
|
if (!lc)
|
||||||
rc = -ENOMEM;
|
return -ENOMEM;
|
||||||
goto out;
|
|
||||||
}
|
|
||||||
|
|
||||||
init_waitqueue_head(&lc->oc_wait);
|
init_waitqueue_head(&lc->oc_wait);
|
||||||
init_completion(&lc->oc_sync_wait);
|
init_completion(&lc->oc_sync_wait);
|
||||||
|
|
Loading…
Reference in New Issue