drm/i915: Treat PCH eDP like DP in most places
PCH eDP has many of the same needs as regular PCH DP connections, including the DP_CTl bit settings, the TRANS_DP_CTL register. Signed-off-by: Keith Packard <keithp@keithp.com> Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
This commit is contained in:
parent
93f62dad5f
commit
417e822dee
|
@ -2933,7 +2933,8 @@ static void ironlake_pch_enable(struct drm_crtc *crtc)
|
||||||
|
|
||||||
/* For PCH DP, enable TRANS_DP_CTL */
|
/* For PCH DP, enable TRANS_DP_CTL */
|
||||||
if (HAS_PCH_CPT(dev) &&
|
if (HAS_PCH_CPT(dev) &&
|
||||||
intel_pipe_has_type(crtc, INTEL_OUTPUT_DISPLAYPORT)) {
|
(intel_pipe_has_type(crtc, INTEL_OUTPUT_DISPLAYPORT) ||
|
||||||
|
intel_pipe_has_type(crtc, INTEL_OUTPUT_EDP))) {
|
||||||
u32 bpc = (I915_READ(PIPECONF(pipe)) & PIPE_BPC_MASK) >> 5;
|
u32 bpc = (I915_READ(PIPECONF(pipe)) & PIPE_BPC_MASK) >> 5;
|
||||||
reg = TRANS_DP_CTL(pipe);
|
reg = TRANS_DP_CTL(pipe);
|
||||||
temp = I915_READ(reg);
|
temp = I915_READ(reg);
|
||||||
|
|
|
@ -766,10 +766,10 @@ intel_dp_set_m_n(struct drm_crtc *crtc, struct drm_display_mode *mode,
|
||||||
continue;
|
continue;
|
||||||
|
|
||||||
intel_dp = enc_to_intel_dp(encoder);
|
intel_dp = enc_to_intel_dp(encoder);
|
||||||
if (intel_dp->base.type == INTEL_OUTPUT_DISPLAYPORT) {
|
if (intel_dp->base.type == INTEL_OUTPUT_DISPLAYPORT || is_pch_edp(intel_dp)) {
|
||||||
lane_count = intel_dp->lane_count;
|
lane_count = intel_dp->lane_count;
|
||||||
break;
|
break;
|
||||||
} else if (is_edp(intel_dp)) {
|
} else if (is_cpu_edp(intel_dp)) {
|
||||||
lane_count = dev_priv->edp.lanes;
|
lane_count = dev_priv->edp.lanes;
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
|
@ -808,6 +808,7 @@ intel_dp_mode_set(struct drm_encoder *encoder, struct drm_display_mode *mode,
|
||||||
struct drm_display_mode *adjusted_mode)
|
struct drm_display_mode *adjusted_mode)
|
||||||
{
|
{
|
||||||
struct drm_device *dev = encoder->dev;
|
struct drm_device *dev = encoder->dev;
|
||||||
|
struct drm_i915_private *dev_priv = dev->dev_private;
|
||||||
struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
|
struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
|
||||||
struct drm_crtc *crtc = intel_dp->base.base.crtc;
|
struct drm_crtc *crtc = intel_dp->base.base.crtc;
|
||||||
struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
|
struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
|
||||||
|
@ -820,18 +821,31 @@ intel_dp_mode_set(struct drm_encoder *encoder, struct drm_display_mode *mode,
|
||||||
ironlake_edp_pll_off(encoder);
|
ironlake_edp_pll_off(encoder);
|
||||||
}
|
}
|
||||||
|
|
||||||
intel_dp->DP = DP_VOLTAGE_0_4 | DP_PRE_EMPHASIS_0;
|
/*
|
||||||
intel_dp->DP |= intel_dp->color_range;
|
* There are three kinds of DP registers:
|
||||||
|
*
|
||||||
|
* IBX PCH
|
||||||
|
* CPU
|
||||||
|
* CPT PCH
|
||||||
|
*
|
||||||
|
* IBX PCH and CPU are the same for almost everything,
|
||||||
|
* except that the CPU DP PLL is configured in this
|
||||||
|
* register
|
||||||
|
*
|
||||||
|
* CPT PCH is quite different, having many bits moved
|
||||||
|
* to the TRANS_DP_CTL register instead. That
|
||||||
|
* configuration happens (oddly) in ironlake_pch_enable
|
||||||
|
*/
|
||||||
|
|
||||||
if (adjusted_mode->flags & DRM_MODE_FLAG_PHSYNC)
|
/* Preserve the BIOS-computed detected bit. This is
|
||||||
intel_dp->DP |= DP_SYNC_HS_HIGH;
|
* supposed to be read-only.
|
||||||
if (adjusted_mode->flags & DRM_MODE_FLAG_PVSYNC)
|
*/
|
||||||
intel_dp->DP |= DP_SYNC_VS_HIGH;
|
intel_dp->DP = I915_READ(intel_dp->output_reg) & DP_DETECTED;
|
||||||
|
intel_dp->DP |= DP_VOLTAGE_0_4 | DP_PRE_EMPHASIS_0;
|
||||||
|
|
||||||
if (HAS_PCH_CPT(dev) && !is_cpu_edp(intel_dp))
|
/* Handle DP bits in common between all three register formats */
|
||||||
intel_dp->DP |= DP_LINK_TRAIN_OFF_CPT;
|
|
||||||
else
|
intel_dp->DP |= DP_VOLTAGE_0_4 | DP_PRE_EMPHASIS_0;
|
||||||
intel_dp->DP |= DP_LINK_TRAIN_OFF;
|
|
||||||
|
|
||||||
switch (intel_dp->lane_count) {
|
switch (intel_dp->lane_count) {
|
||||||
case 1:
|
case 1:
|
||||||
|
@ -850,32 +864,45 @@ intel_dp_mode_set(struct drm_encoder *encoder, struct drm_display_mode *mode,
|
||||||
intel_dp->DP |= DP_AUDIO_OUTPUT_ENABLE;
|
intel_dp->DP |= DP_AUDIO_OUTPUT_ENABLE;
|
||||||
intel_write_eld(encoder, adjusted_mode);
|
intel_write_eld(encoder, adjusted_mode);
|
||||||
}
|
}
|
||||||
|
|
||||||
memset(intel_dp->link_configuration, 0, DP_LINK_CONFIGURATION_SIZE);
|
memset(intel_dp->link_configuration, 0, DP_LINK_CONFIGURATION_SIZE);
|
||||||
intel_dp->link_configuration[0] = intel_dp->link_bw;
|
intel_dp->link_configuration[0] = intel_dp->link_bw;
|
||||||
intel_dp->link_configuration[1] = intel_dp->lane_count;
|
intel_dp->link_configuration[1] = intel_dp->lane_count;
|
||||||
intel_dp->link_configuration[8] = DP_SET_ANSI_8B10B;
|
intel_dp->link_configuration[8] = DP_SET_ANSI_8B10B;
|
||||||
|
|
||||||
/*
|
/*
|
||||||
* Check for DPCD version > 1.1 and enhanced framing support
|
* Check for DPCD version > 1.1 and enhanced framing support
|
||||||
*/
|
*/
|
||||||
if (intel_dp->dpcd[DP_DPCD_REV] >= 0x11 &&
|
if (intel_dp->dpcd[DP_DPCD_REV] >= 0x11 &&
|
||||||
(intel_dp->dpcd[DP_MAX_LANE_COUNT] & DP_ENHANCED_FRAME_CAP)) {
|
(intel_dp->dpcd[DP_MAX_LANE_COUNT] & DP_ENHANCED_FRAME_CAP)) {
|
||||||
intel_dp->link_configuration[1] |= DP_LANE_COUNT_ENHANCED_FRAME_EN;
|
intel_dp->link_configuration[1] |= DP_LANE_COUNT_ENHANCED_FRAME_EN;
|
||||||
intel_dp->DP |= DP_ENHANCED_FRAMING;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/* CPT DP's pipe select is decided in TRANS_DP_CTL */
|
/* Split out the IBX/CPU vs CPT settings */
|
||||||
if (intel_crtc->pipe == 1 && !HAS_PCH_CPT(dev))
|
|
||||||
intel_dp->DP |= DP_PIPEB_SELECT;
|
|
||||||
|
|
||||||
if (is_cpu_edp(intel_dp)) {
|
if (!HAS_PCH_CPT(dev) || is_cpu_edp(intel_dp)) {
|
||||||
/* don't miss out required setting for eDP */
|
intel_dp->DP |= intel_dp->color_range;
|
||||||
intel_dp->DP |= DP_PLL_ENABLE;
|
|
||||||
if (adjusted_mode->clock < 200000)
|
if (adjusted_mode->flags & DRM_MODE_FLAG_PHSYNC)
|
||||||
intel_dp->DP |= DP_PLL_FREQ_160MHZ;
|
intel_dp->DP |= DP_SYNC_HS_HIGH;
|
||||||
else
|
if (adjusted_mode->flags & DRM_MODE_FLAG_PVSYNC)
|
||||||
intel_dp->DP |= DP_PLL_FREQ_270MHZ;
|
intel_dp->DP |= DP_SYNC_VS_HIGH;
|
||||||
|
intel_dp->DP |= DP_LINK_TRAIN_OFF;
|
||||||
|
|
||||||
|
if (intel_dp->link_configuration[1] & DP_LANE_COUNT_ENHANCED_FRAME_EN)
|
||||||
|
intel_dp->DP |= DP_ENHANCED_FRAMING;
|
||||||
|
|
||||||
|
if (intel_crtc->pipe == 1)
|
||||||
|
intel_dp->DP |= DP_PIPEB_SELECT;
|
||||||
|
|
||||||
|
if (is_cpu_edp(intel_dp)) {
|
||||||
|
/* don't miss out required setting for eDP */
|
||||||
|
intel_dp->DP |= DP_PLL_ENABLE;
|
||||||
|
if (adjusted_mode->clock < 200000)
|
||||||
|
intel_dp->DP |= DP_PLL_FREQ_160MHZ;
|
||||||
|
else
|
||||||
|
intel_dp->DP |= DP_PLL_FREQ_270MHZ;
|
||||||
|
}
|
||||||
|
} else {
|
||||||
|
intel_dp->DP |= DP_LINK_TRAIN_OFF_CPT;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -1341,6 +1368,7 @@ static char *link_train_names[] = {
|
||||||
* a maximum voltage of 800mV and a maximum pre-emphasis of 6dB
|
* a maximum voltage of 800mV and a maximum pre-emphasis of 6dB
|
||||||
*/
|
*/
|
||||||
#define I830_DP_VOLTAGE_MAX DP_TRAIN_VOLTAGE_SWING_800
|
#define I830_DP_VOLTAGE_MAX DP_TRAIN_VOLTAGE_SWING_800
|
||||||
|
#define I830_DP_VOLTAGE_MAX_CPT DP_TRAIN_VOLTAGE_SWING_1200
|
||||||
|
|
||||||
static uint8_t
|
static uint8_t
|
||||||
intel_dp_pre_emphasis_max(uint8_t voltage_swing)
|
intel_dp_pre_emphasis_max(uint8_t voltage_swing)
|
||||||
|
@ -1378,8 +1406,12 @@ intel_get_adjust_train(struct intel_dp *intel_dp, uint8_t link_status[DP_LINK_ST
|
||||||
p = this_p;
|
p = this_p;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (v >= I830_DP_VOLTAGE_MAX)
|
if (HAS_PCH_CPT(dev) && !is_cpu_edp(intel_dp))
|
||||||
v = I830_DP_VOLTAGE_MAX | DP_TRAIN_MAX_SWING_REACHED;
|
voltage_max = I830_DP_VOLTAGE_MAX_CPT;
|
||||||
|
else
|
||||||
|
voltage_max = I830_DP_VOLTAGE_MAX;
|
||||||
|
if (v >= voltage_max)
|
||||||
|
v = voltage_max | DP_TRAIN_MAX_SWING_REACHED;
|
||||||
|
|
||||||
if (p >= intel_dp_pre_emphasis_max(v))
|
if (p >= intel_dp_pre_emphasis_max(v))
|
||||||
p = intel_dp_pre_emphasis_max(v) | DP_TRAIN_MAX_PRE_EMPHASIS_REACHED;
|
p = intel_dp_pre_emphasis_max(v) | DP_TRAIN_MAX_PRE_EMPHASIS_REACHED;
|
||||||
|
@ -1570,7 +1602,8 @@ intel_dp_start_link_train(struct intel_dp *intel_dp)
|
||||||
/* Use intel_dp->train_set[0] to set the voltage and pre emphasis values */
|
/* Use intel_dp->train_set[0] to set the voltage and pre emphasis values */
|
||||||
uint8_t link_status[DP_LINK_STATUS_SIZE];
|
uint8_t link_status[DP_LINK_STATUS_SIZE];
|
||||||
uint32_t signal_levels;
|
uint32_t signal_levels;
|
||||||
if (IS_GEN6(dev) && is_edp(intel_dp)) {
|
|
||||||
|
if (IS_GEN6(dev) && is_cpu_edp(intel_dp)) {
|
||||||
signal_levels = intel_gen6_edp_signal_levels(intel_dp->train_set[0]);
|
signal_levels = intel_gen6_edp_signal_levels(intel_dp->train_set[0]);
|
||||||
DP = (DP & ~EDP_LINK_TRAIN_VOL_EMP_MASK_SNB) | signal_levels;
|
DP = (DP & ~EDP_LINK_TRAIN_VOL_EMP_MASK_SNB) | signal_levels;
|
||||||
} else {
|
} else {
|
||||||
|
@ -1650,12 +1683,11 @@ intel_dp_complete_link_train(struct intel_dp *intel_dp)
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (IS_GEN6(dev) && is_edp(intel_dp)) {
|
if (IS_GEN6(dev) && is_cpu_edp(intel_dp)) {
|
||||||
signal_levels = intel_gen6_edp_signal_levels(intel_dp->train_set[0]);
|
signal_levels = intel_gen6_edp_signal_levels(intel_dp->train_set[0]);
|
||||||
DP = (DP & ~EDP_LINK_TRAIN_VOL_EMP_MASK_SNB) | signal_levels;
|
DP = (DP & ~EDP_LINK_TRAIN_VOL_EMP_MASK_SNB) | signal_levels;
|
||||||
} else {
|
} else {
|
||||||
signal_levels = intel_dp_signal_levels(intel_dp->train_set[0]);
|
signal_levels = intel_dp_signal_levels(intel_dp->train_set[0]);
|
||||||
DRM_DEBUG_KMS("training pattern 1 signal levels %08x\n", signal_levels);
|
|
||||||
DP = (DP & ~(DP_VOLTAGE_MASK|DP_PRE_EMPHASIS_MASK)) | signal_levels;
|
DP = (DP & ~(DP_VOLTAGE_MASK|DP_PRE_EMPHASIS_MASK)) | signal_levels;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -1741,8 +1773,12 @@ intel_dp_link_down(struct intel_dp *intel_dp)
|
||||||
|
|
||||||
msleep(17);
|
msleep(17);
|
||||||
|
|
||||||
if (is_edp(intel_dp))
|
if (is_edp(intel_dp)) {
|
||||||
DP |= DP_LINK_TRAIN_OFF;
|
if (HAS_PCH_CPT(dev) && !is_cpu_edp(intel_dp))
|
||||||
|
DP |= DP_LINK_TRAIN_OFF_CPT;
|
||||||
|
else
|
||||||
|
DP |= DP_LINK_TRAIN_OFF;
|
||||||
|
}
|
||||||
|
|
||||||
if (!HAS_PCH_CPT(dev) &&
|
if (!HAS_PCH_CPT(dev) &&
|
||||||
I915_READ(intel_dp->output_reg) & DP_PIPEB_SELECT) {
|
I915_READ(intel_dp->output_reg) & DP_PIPEB_SELECT) {
|
||||||
|
@ -2186,7 +2222,8 @@ intel_trans_dp_port_sel(struct drm_crtc *crtc)
|
||||||
continue;
|
continue;
|
||||||
|
|
||||||
intel_dp = enc_to_intel_dp(encoder);
|
intel_dp = enc_to_intel_dp(encoder);
|
||||||
if (intel_dp->base.type == INTEL_OUTPUT_DISPLAYPORT)
|
if (intel_dp->base.type == INTEL_OUTPUT_DISPLAYPORT ||
|
||||||
|
intel_dp->base.type == INTEL_OUTPUT_EDP)
|
||||||
return intel_dp->output_reg;
|
return intel_dp->output_reg;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue