hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

audit: do not call audit_getname on error 

Just a code cleanup really.  We don't need to make a function call just for
it to return on error.  This also makes the VFS function even easier to follow
and removes a conditional on a hot path.

Signed-off-by: Eric Paris <eparis@redhat.com>
This commit is contained in:
Eric Paris 2012-01-03 14:23:08 -05:00 committed by Al Viro
parent 633b454545
commit 4043cde8ec
2 changed files with 11 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
fs/namei.c
View File

@ -140,21 +140,19 @@ static int do_getname(const char __user *filename, char *page)
static char *getname_flags(const char __user *filename, int flags, int *empty) static char *getname_flags(const char __user *filename, int flags, int *empty)
{ {
char *tmp, *result; char *result = __getname();
int retval;
result = ERR_PTR(-ENOMEM); if (!result)
tmp = __getname(); return ERR_PTR(-ENOMEM);
if (tmp) {
int retval = do_getname(filename, tmp);
result = tmp; retval = do_getname(filename, result);
if (retval < 0) { if (retval < 0) {
if (retval == -ENOENT && empty) if (retval == -ENOENT && empty)
*empty = 1; *empty = 1;
if (retval != -ENOENT || !(flags & LOOKUP_EMPTY)) { if (retval != -ENOENT || !(flags & LOOKUP_EMPTY)) {
__putname(tmp); __putname(result);
result = ERR_PTR(retval); return ERR_PTR(retval);
}
} }
} }
audit_getname(result); audit_getname(result);

3
kernel/auditsc.c
View File

@ -1913,9 +1913,6 @@ void __audit_getname(const char *name)
struct audit_context *context = current->audit_context; struct audit_context *context = current->audit_context;
struct audit_names *n; struct audit_names *n;
if (IS_ERR(name) || !name)
return;
if (!context->in_syscall) { if (!context->in_syscall) {
#if AUDIT_DEBUG == 2 #if AUDIT_DEBUG == 2
printk(KERN_ERR "%s:%d(:%d): ignoring getname(%p)\n", printk(KERN_ERR "%s:%d(:%d): ignoring getname(%p)\n",