From 3e089d9f55acfe9edd8a71d19cfc3129ab3a37f8 Mon Sep 17 00:00:00 2001 From: Sudip Mukherjee Date: Fri, 19 Feb 2016 14:53:00 +0530 Subject: [PATCH] gpio: pisosr: add missing unlock If spi_read() fails then we just returned but we missed unlocking the mutex. Signed-off-by: Sudip Mukherjee Signed-off-by: Linus Walleij --- drivers/gpio/gpio-pisosr.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-pisosr.c b/drivers/gpio/gpio-pisosr.c index 58ea08dfdfce..f9f1074744ab 100644 --- a/drivers/gpio/gpio-pisosr.c +++ b/drivers/gpio/gpio-pisosr.c @@ -53,12 +53,10 @@ static int pisosr_gpio_refresh(struct pisosr_gpio *gpio) } ret = spi_read(gpio->spi, gpio->buffer, gpio->buffer_size); - if (ret) - return ret; mutex_unlock(&gpio->lock); - return 0; + return ret; } static int pisosr_gpio_get_direction(struct gpio_chip *chip,