extcon: ptn5150: Fix return value check in ptn5150_i2c_probe()
In case of error, the function devm_gpiod_get() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
This commit is contained in:
parent
4ed754de2d
commit
3dfed89512
|
@ -240,14 +240,14 @@ static int ptn5150_i2c_probe(struct i2c_client *i2c,
|
||||||
info->dev = &i2c->dev;
|
info->dev = &i2c->dev;
|
||||||
info->i2c = i2c;
|
info->i2c = i2c;
|
||||||
info->int_gpiod = devm_gpiod_get(&i2c->dev, "int", GPIOD_IN);
|
info->int_gpiod = devm_gpiod_get(&i2c->dev, "int", GPIOD_IN);
|
||||||
if (!info->int_gpiod) {
|
if (IS_ERR(info->int_gpiod)) {
|
||||||
dev_err(dev, "failed to get INT GPIO\n");
|
dev_err(dev, "failed to get INT GPIO\n");
|
||||||
return -EINVAL;
|
return PTR_ERR(info->int_gpiod);
|
||||||
}
|
}
|
||||||
info->vbus_gpiod = devm_gpiod_get(&i2c->dev, "vbus", GPIOD_IN);
|
info->vbus_gpiod = devm_gpiod_get(&i2c->dev, "vbus", GPIOD_IN);
|
||||||
if (!info->vbus_gpiod) {
|
if (IS_ERR(info->vbus_gpiod)) {
|
||||||
dev_err(dev, "failed to get VBUS GPIO\n");
|
dev_err(dev, "failed to get VBUS GPIO\n");
|
||||||
return -EINVAL;
|
return PTR_ERR(info->vbus_gpiod);
|
||||||
}
|
}
|
||||||
ret = gpiod_direction_output(info->vbus_gpiod, 0);
|
ret = gpiod_direction_output(info->vbus_gpiod, 0);
|
||||||
if (ret) {
|
if (ret) {
|
||||||
|
|
Loading…
Reference in New Issue