hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[media] rc: Deletion of unnecessary checks before two function calls 

The functions input_free_device() and rc_close() test whether their argument
is NULL and then return immediately. Thus the test around the call
is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
This commit is contained in:
Markus Elfring 2014-11-20 09:01:32 -03:00 committed by Mauro Carvalho Chehab
parent 8f1aeedf78
commit 3dd94f00f0
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/media/rc/lirc_dev.c
View File

@ -518,8 +518,7 @@ int lirc_dev_fop_close(struct inode *inode, struct file *file)
WARN_ON(mutex_lock_killable(&lirc_dev_lock));
if (ir->d.rdev)
rc_close(ir->d.rdev);
rc_close(ir->d.rdev);
ir->open--;
if (ir->attached) {

3
drivers/media/rc/rc-main.c
View File

@ -1298,8 +1298,7 @@ void rc_free_device(struct rc_dev *dev)
if (!dev)
return;
if (dev->input_dev)
input_free_device(dev->input_dev);
input_free_device(dev->input_dev);
put_device(&dev->dev);