target: fixup error message in target_tg_pt_gp_tg_pt_gp_id_store()
When setting up an ALUA target port group with an invalid ID the error message kstrtoul() returned -22 for tg_pt_gp_id is displayed, which is not really helpful. Convert it to something sane. And while we're at it, join the messages onto a single line. Signed-by: Hannes Reinecke <hare@suse.com> Reviewed-by: Bart van Assche <bart.vanassche@sandisk.com> Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
This commit is contained in:
parent
c0dcafd8c5
commit
3d035237a5
|
@ -2677,13 +2677,13 @@ static ssize_t target_tg_pt_gp_tg_pt_gp_id_store(struct config_item *item,
|
|||
|
||||
ret = kstrtoul(page, 0, &tg_pt_gp_id);
|
||||
if (ret < 0) {
|
||||
pr_err("kstrtoul() returned %d for"
|
||||
" tg_pt_gp_id\n", ret);
|
||||
pr_err("ALUA tg_pt_gp_id: invalid value '%s' for tg_pt_gp_id\n",
|
||||
page);
|
||||
return ret;
|
||||
}
|
||||
if (tg_pt_gp_id > 0x0000ffff) {
|
||||
pr_err("ALUA tg_pt_gp_id: %lu exceeds maximum:"
|
||||
" 0x0000ffff\n", tg_pt_gp_id);
|
||||
pr_err("ALUA tg_pt_gp_id: %lu exceeds maximum: 0x0000ffff\n",
|
||||
tg_pt_gp_id);
|
||||
return -EINVAL;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in New Issue