hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

staging: vc04_services: no need to save the log debufs dentries 

The log entry dentries are only set, never referenced, so no need to
keep them around.  Remove the pointer from struct
vchiq_debugfs_log_entry as it is not needed anymore and get rid of the
separate vchiq_debugfs_create_log_entries() function as it is only used
in one place.

Suggested-by: Eric Anholt <eric@anholt.net>
Cc: Stefan Wahren <stefan.wahren@i2se.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Keerthi Reddy <keerthigd4990@gmail.com>
Cc: linux-rpi-kernel@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org
Reviewed-by: Eric Anholt <eric@anholt.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Greg Kroah-Hartman 2018-06-01 13:10:04 +02:00
parent 54f156968a
commit 3b93c0f4b6
1 changed files with 10 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_debugfs.c
View File

@ -59,7 +59,6 @@ struct dentry *vchiq_dbg_clients;
struct vchiq_debugfs_log_entry {
const char *name;
void *plevel;
struct dentry *dir;
};
static struct vchiq_debugfs_log_entry vchiq_debugfs_log_entries[] = {
@ -144,23 +143,6 @@ static const struct file_operations debugfs_log_fops = {
.release = single_release,
};
/* create an entry under <debugfs>/vchiq/log for each log category */
static void vchiq_debugfs_create_log_entries(struct dentry *top)
{
struct dentry *dir;
size_t i;
dir = debugfs_create_dir("log", vchiq_dbg_dir);
for (i = 0; i < n_log_entries; i++) {
dir = debugfs_create_file(vchiq_debugfs_log_entries[i].name,
0644, dir,
vchiq_debugfs_log_entries[i].plevel,
&debugfs_log_fops);
vchiq_debugfs_log_entries[i].dir = dir;
}
}
static int debugfs_usecount_show(struct seq_file *f, void *offset)
{
VCHIQ_INSTANCE_T instance = f->private;
@ -268,10 +250,19 @@ void vchiq_debugfs_remove_instance(VCHIQ_INSTANCE_T instance)
void vchiq_debugfs_init(void)
{
struct dentry *dir;
int i;
vchiq_dbg_dir = debugfs_create_dir("vchiq", NULL);
vchiq_dbg_clients = debugfs_create_dir("clients", vchiq_dbg_dir);
vchiq_debugfs_create_log_entries(vchiq_dbg_dir);
/* create an entry under <debugfs>/vchiq/log for each log category */
dir = debugfs_create_dir("log", vchiq_dbg_dir);
for (i = 0; i < n_log_entries; i++)
debugfs_create_file(vchiq_debugfs_log_entries[i].name, 0644,
dir, vchiq_debugfs_log_entries[i].plevel,
&debugfs_log_fops);
}
/* remove all the debugfs entries */