perf build: Do not use -Wshadow on gcc < 4.8
As it is too strict, see https://lkml.org/lkml/2006/11/28/253 and https://gcc.gnu.org/gcc-4.8/changes.html, that takes into account Linus's comments (search for Wshadow) for the reasoning about -Wshadow not being interesting before gcc 4.8. Acked-by: Andrii Nakryiko <andrii.nakryiko@gmail.com> Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Namhyung Kim <namhyung@kernel.org> Link: https://lkml.kernel.org/r/20190719183417.GQ3624@kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
parent
d95daf5acc
commit
39e7317e37
|
@ -32,7 +32,6 @@ EXTRA_WARNINGS += -Wno-system-headers
|
|||
EXTRA_WARNINGS += -Wold-style-definition
|
||||
EXTRA_WARNINGS += -Wpacked
|
||||
EXTRA_WARNINGS += -Wredundant-decls
|
||||
EXTRA_WARNINGS += -Wshadow
|
||||
EXTRA_WARNINGS += -Wstrict-prototypes
|
||||
EXTRA_WARNINGS += -Wswitch-default
|
||||
EXTRA_WARNINGS += -Wswitch-enum
|
||||
|
@ -69,8 +68,16 @@ endif
|
|||
# will do for now and keep the above -Wstrict-aliasing=3 in place
|
||||
# in newer systems.
|
||||
# Needed for the __raw_cmpxchg in tools/arch/x86/include/asm/cmpxchg.h
|
||||
#
|
||||
# See https://lkml.org/lkml/2006/11/28/253 and https://gcc.gnu.org/gcc-4.8/changes.html,
|
||||
# that takes into account Linus's comments (search for Wshadow) for the reasoning about
|
||||
# -Wshadow not being interesting before gcc 4.8.
|
||||
|
||||
ifneq ($(filter 3.%,$(MAKE_VERSION)),) # make-3
|
||||
EXTRA_WARNINGS += -fno-strict-aliasing
|
||||
EXTRA_WARNINGS += -Wno-shadow
|
||||
else
|
||||
EXTRA_WARNINGS += -Wshadow
|
||||
endif
|
||||
|
||||
ifneq ($(findstring $(MAKEFLAGS), w),w)
|
||||
|
|
Loading…
Reference in New Issue