hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

USB: legotower: remove direct calls to printk() 

Use the pr_* calls instead, which are much more descriptive.

Cc: Juergen Stuber <starblue@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Greg Kroah-Hartman 2013-06-26 16:30:42 -07:00
parent 4dae996380
commit 38726bf541
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/usb/misc/legousbtower.c
View File

@ -75,6 +75,8 @@
* - move reset into open to clean out spurious data * - move reset into open to clean out spurious data
*/ */
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
#include <linux/kernel.h> #include <linux/kernel.h>
#include <linux/errno.h> #include <linux/errno.h>
#include <linux/init.h> #include <linux/init.h>
@ -325,8 +327,7 @@ static int tower_open (struct inode *inode, struct file *file)
interface = usb_find_interface (&tower_driver, subminor); interface = usb_find_interface (&tower_driver, subminor);
if (!interface) { if (!interface) {
printk(KERN_ERR "%s - error, can't find device for minor %d\n", pr_err("error, can't find device for minor %d\n", subminor);
__func__, subminor);
retval = -ENODEV; retval = -ENODEV;
goto exit; goto exit;
} }
@ -563,7 +564,7 @@ static ssize_t tower_read (struct file *file, char __user *buffer, size_t count,
/* verify that the device wasn't unplugged */ /* verify that the device wasn't unplugged */
if (dev->udev == NULL) { if (dev->udev == NULL) {
retval = -ENODEV; retval = -ENODEV;
printk(KERN_ERR "legousbtower: No device or device unplugged %d\n", retval); pr_err("No device or device unplugged %d\n", retval);
goto unlock_exit; goto unlock_exit;
} }
@ -649,7 +650,7 @@ static ssize_t tower_write (struct file *file, const char __user *buffer, size_t
/* verify that the device wasn't unplugged */ /* verify that the device wasn't unplugged */
if (dev->udev == NULL) { if (dev->udev == NULL) {
retval = -ENODEV; retval = -ENODEV;
printk(KERN_ERR "legousbtower: No device or device unplugged %d\n", retval); pr_err("No device or device unplugged %d\n", retval);
goto unlock_exit; goto unlock_exit;
} }
@ -748,7 +749,8 @@ static void tower_interrupt_in_callback (struct urb *urb)
dev_dbg(&dev->udev->dev, "%s: received %d bytes\n", dev_dbg(&dev->udev->dev, "%s: received %d bytes\n",
__func__, urb->actual_length); __func__, urb->actual_length);
} else { } else {
printk(KERN_WARNING "%s: read_buffer overflow, %d bytes dropped", __func__, urb->actual_length); pr_warn("read_buffer overflow, %d bytes dropped\n",
urb->actual_length);
} }
spin_unlock (&dev->read_buffer_lock); spin_unlock (&dev->read_buffer_lock);
} }