hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

iser-target: Fix non negative ERR_PTR isert_device_get usage 

As reported by Dan, isert_create_device_ib_res() failure within
isert_device_get() can potentially return a postive value,
resulting in ERR_PTR() triggering a NULL pointer dereference.

Caught by the static checker:

     drivers/infiniband/ulp/isert/ib_isert.c:423 isert_device_get()
     error: passing non negative 1 to ERR_PTR

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Sagi Grimberg <sagig@mellanox.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
This commit is contained in:
Nicholas Bellinger 2016-01-06 10:25:43 -08:00
parent 091b70623e
commit 373a4cd737
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/infiniband/ulp/isert/ib_isert.c
View File

@ -357,7 +357,7 @@ isert_create_device_ib_res(struct isert_device *device)
dev_attr = &device->dev_attr; dev_attr = &device->dev_attr;
ret = isert_query_device(device->ib_device, dev_attr); ret = isert_query_device(device->ib_device, dev_attr);
if (ret) if (ret)
return ret; goto out;
/* asign function handlers */ /* asign function handlers */
if (dev_attr->device_cap_flags & IB_DEVICE_MEM_MGT_EXTENSIONS && if (dev_attr->device_cap_flags & IB_DEVICE_MEM_MGT_EXTENSIONS &&
@ -373,7 +373,7 @@ isert_create_device_ib_res(struct isert_device *device)
ret = isert_alloc_comps(device, dev_attr); ret = isert_alloc_comps(device, dev_attr);
if (ret) if (ret)
return ret; goto out;
device->pd = ib_alloc_pd(device->ib_device); device->pd = ib_alloc_pd(device->ib_device);
if (IS_ERR(device->pd)) { if (IS_ERR(device->pd)) {
@ -391,6 +391,9 @@ isert_create_device_ib_res(struct isert_device *device)
out_cq: out_cq:
isert_free_comps(device); isert_free_comps(device);
out:
if (ret > 0)
ret = -EINVAL;
return ret; return ret;
} }