drm/i915: Convert wait_for(I915_READ(reg)) to intel_wait_for_register()
By using the out-of-line intel_wait_for_register() not only do we can efficiency from using the hybrid wait_for() contained within, but we avoid code bloat from the numerous inlined loops, in total (all patches): text data bss dec hex filename 1078551 4557 416 1083524 108884 drivers/gpu/drm/i915/i915.ko 1070775 4557 416 1075748 106a24 drivers/gpu/drm/i915/i915.ko Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Link: http://patchwork.freedesktop.org/patch/msgid/1467297225-21379-13-git-send-email-chris@chris-wilson.co.uk
This commit is contained in:
parent
6b18826a9e
commit
370004d38a
|
@ -1820,7 +1820,9 @@ void vlv_wait_port_ready(struct drm_i915_private *dev_priv,
|
|||
BUG();
|
||||
}
|
||||
|
||||
if (wait_for((I915_READ(dpll_reg) & port_mask) == expected_mask, 1000))
|
||||
if (intel_wait_for_register(dev_priv,
|
||||
dpll_reg, port_mask, expected_mask,
|
||||
1000))
|
||||
WARN(1, "timed out waiting for port %c ready: got 0x%x, expected 0x%x\n",
|
||||
port_name(dport->port), I915_READ(dpll_reg) & port_mask, expected_mask);
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue