hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

mtd: bcm47xxpart: don't fail because of bit-flips 

Bit-flip errors may occur on NAND flashes and are harmless. Handle them
gracefully as read content is still reliable and can be parsed.

Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
This commit is contained in:
Rafał Miłecki 2015-12-06 11:31:38 +01:00 committed by Brian Norris
parent 2a36a5c30e
commit 36bcc0c9c2
1 changed files with 22 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
drivers/mtd/bcm47xxpart.c
View File

@ -66,11 +66,13 @@ static const char *bcm47xxpart_trx_data_part_name(struct mtd_info *master,
{ {
uint32_t buf; uint32_t buf;
size_t bytes_read; size_t bytes_read;
int err;
if (mtd_read(master, offset, sizeof(buf), &bytes_read, err = mtd_read(master, offset, sizeof(buf), &bytes_read,
(uint8_t *)&buf) < 0) { (uint8_t *)&buf);
pr_err("mtd_read error while parsing (offset: 0x%X)!\n", if (err && !mtd_is_bitflip(err)) {
offset); pr_err("mtd_read error while parsing (offset: 0x%X): %d\n",
offset, err);
goto out_default; goto out_default;
} }
@ -95,6 +97,7 @@ static int bcm47xxpart_parse(struct mtd_info *master,
int trx_part = -1; int trx_part = -1;
int last_trx_part = -1; int last_trx_part = -1;
int possible_nvram_sizes[] = { 0x8000, 0xF000, 0x10000, }; int possible_nvram_sizes[] = { 0x8000, 0xF000, 0x10000, };
int err;
/* /*
* Some really old flashes (like AT45DB*) had smaller erasesize-s, but * Some really old flashes (like AT45DB*) had smaller erasesize-s, but
@ -128,10 +131,11 @@ static int bcm47xxpart_parse(struct mtd_info *master,
} }
/* Read beginning of the block */ /* Read beginning of the block */
if (mtd_read(master, offset, BCM47XXPART_BYTES_TO_READ, err = mtd_read(master, offset, BCM47XXPART_BYTES_TO_READ,
&bytes_read, (uint8_t *)buf) < 0) { &bytes_read, (uint8_t *)buf);
pr_err("mtd_read error while parsing (offset: 0x%X)!\n", if (err && !mtd_is_bitflip(err)) {
offset); pr_err("mtd_read error while parsing (offset: 0x%X): %d\n",
offset, err);
continue; continue;
} }
@ -254,10 +258,11 @@ static int bcm47xxpart_parse(struct mtd_info *master,
} }
/* Read middle of the block */ /* Read middle of the block */
if (mtd_read(master, offset + 0x8000, 0x4, err = mtd_read(master, offset + 0x8000, 0x4, &bytes_read,
&bytes_read, (uint8_t *)buf) < 0) { (uint8_t *)buf);
pr_err("mtd_read error while parsing (offset: 0x%X)!\n", if (err && !mtd_is_bitflip(err)) {
offset); pr_err("mtd_read error while parsing (offset: 0x%X): %d\n",
offset, err);
continue; continue;
} }
@ -277,10 +282,11 @@ static int bcm47xxpart_parse(struct mtd_info *master,
} }
offset = master->size - possible_nvram_sizes[i]; offset = master->size - possible_nvram_sizes[i];
if (mtd_read(master, offset, 0x4, &bytes_read, err = mtd_read(master, offset, 0x4, &bytes_read,
(uint8_t *)buf) < 0) { (uint8_t *)buf);
pr_err("mtd_read error while reading at offset 0x%X!\n", if (err && !mtd_is_bitflip(err)) {
offset); pr_err("mtd_read error while reading (offset 0x%X): %d\n",
offset, err);
continue; continue;
} }