drm/qxl: use kmalloc_array to alloc reloc_info in qxl_process_single_command
This avoids integer overflows on 32bit machines when calculating reloc_info size, as reported by Alan Cox. Cc: stable@vger.kernel.org Cc: gnomes@lxorguk.ukuu.org.uk Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Signed-off-by: Dave Airlie <airlied@redhat.com>
This commit is contained in:
parent
e8f051e9d8
commit
34855706c3
|
@ -168,7 +168,8 @@ static int qxl_process_single_command(struct qxl_device *qdev,
|
|||
cmd->command_size))
|
||||
return -EFAULT;
|
||||
|
||||
reloc_info = kmalloc(sizeof(struct qxl_reloc_info) * cmd->relocs_num, GFP_KERNEL);
|
||||
reloc_info = kmalloc_array(cmd->relocs_num,
|
||||
sizeof(struct qxl_reloc_info), GFP_KERNEL);
|
||||
if (!reloc_info)
|
||||
return -ENOMEM;
|
||||
|
||||
|
|
Loading…
Reference in New Issue