hisi_sas: add hisi_sas_slave_configure()
In high-datarate aging tests, it is found that the SCSI framework can periodically issue lu resets as some commands timeout. Response TASK SET FULL and SAS_QUEUE_FULL may be returned many times for the same command, causing the timeouts. The SAS_QUEUE_FULL errors come from TRANS_TX_CREDIT_TIMEOUT_ERR, TRANS_TX_CLOSE_NORMAL_ERR, and TRANS_TX_ERR_FRAME_TXED errors. They do not mean that the queue is full in the host, but rather it is equivalent to meaning the queue is full for the sdev. To overcome this, the queue depth for the sdev is reduced to 64 (from 256, set in sas_slave_configure()). Normally error code SAS_QUEUE_FULL will result in the sdev queue depth falling, but it falls too slowly during high-datarate tests and commands timeout before it has fallen to an adequete level from original value. Signed-off-by: John Garry <john.garry@huawei.com> Reviewed-by: Hannes Reinecke <hare@suse.de> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
parent
9c8ee657cf
commit
31eec8a6c0
|
@ -453,6 +453,19 @@ static int hisi_sas_dev_found(struct domain_device *device)
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
static int hisi_sas_slave_configure(struct scsi_device *sdev)
|
||||||
|
{
|
||||||
|
struct domain_device *dev = sdev_to_domain_dev(sdev);
|
||||||
|
int ret = sas_slave_configure(sdev);
|
||||||
|
|
||||||
|
if (ret)
|
||||||
|
return ret;
|
||||||
|
if (!dev_is_sata(dev))
|
||||||
|
sas_change_queue_depth(sdev, 64);
|
||||||
|
|
||||||
|
return 0;
|
||||||
|
}
|
||||||
|
|
||||||
static void hisi_sas_scan_start(struct Scsi_Host *shost)
|
static void hisi_sas_scan_start(struct Scsi_Host *shost)
|
||||||
{
|
{
|
||||||
struct hisi_hba *hisi_hba = shost_priv(shost);
|
struct hisi_hba *hisi_hba = shost_priv(shost);
|
||||||
|
@ -990,7 +1003,7 @@ static struct scsi_host_template hisi_sas_sht = {
|
||||||
.name = DRV_NAME,
|
.name = DRV_NAME,
|
||||||
.queuecommand = sas_queuecommand,
|
.queuecommand = sas_queuecommand,
|
||||||
.target_alloc = sas_target_alloc,
|
.target_alloc = sas_target_alloc,
|
||||||
.slave_configure = sas_slave_configure,
|
.slave_configure = hisi_sas_slave_configure,
|
||||||
.scan_finished = hisi_sas_scan_finished,
|
.scan_finished = hisi_sas_scan_finished,
|
||||||
.scan_start = hisi_sas_scan_start,
|
.scan_start = hisi_sas_scan_start,
|
||||||
.change_queue_depth = sas_change_queue_depth,
|
.change_queue_depth = sas_change_queue_depth,
|
||||||
|
|
Loading…
Reference in New Issue