io_uring: clean up io_uring_cancel_files()
We don't use the return value anymore, drop it. Also drop the unecessary double cancel_req value check. Signed-off-by: Bob Liu <bob.liu@oracle.com> Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
parent
e61df66c69
commit
2f6d9b9d63
|
@ -4303,7 +4303,6 @@ static void io_uring_cancel_files(struct io_ring_ctx *ctx,
|
||||||
DEFINE_WAIT(wait);
|
DEFINE_WAIT(wait);
|
||||||
|
|
||||||
while (!list_empty_careful(&ctx->inflight_list)) {
|
while (!list_empty_careful(&ctx->inflight_list)) {
|
||||||
enum io_wq_cancel ret = IO_WQ_CANCEL_NOTFOUND;
|
|
||||||
struct io_kiocb *cancel_req = NULL;
|
struct io_kiocb *cancel_req = NULL;
|
||||||
|
|
||||||
spin_lock_irq(&ctx->inflight_lock);
|
spin_lock_irq(&ctx->inflight_lock);
|
||||||
|
@ -4321,14 +4320,12 @@ static void io_uring_cancel_files(struct io_ring_ctx *ctx,
|
||||||
TASK_UNINTERRUPTIBLE);
|
TASK_UNINTERRUPTIBLE);
|
||||||
spin_unlock_irq(&ctx->inflight_lock);
|
spin_unlock_irq(&ctx->inflight_lock);
|
||||||
|
|
||||||
if (cancel_req) {
|
|
||||||
ret = io_wq_cancel_work(ctx->io_wq, &cancel_req->work);
|
|
||||||
io_put_req(cancel_req);
|
|
||||||
}
|
|
||||||
|
|
||||||
/* We need to keep going until we don't find a matching req */
|
/* We need to keep going until we don't find a matching req */
|
||||||
if (!cancel_req)
|
if (!cancel_req)
|
||||||
break;
|
break;
|
||||||
|
|
||||||
|
io_wq_cancel_work(ctx->io_wq, &cancel_req->work);
|
||||||
|
io_put_req(cancel_req);
|
||||||
schedule();
|
schedule();
|
||||||
}
|
}
|
||||||
finish_wait(&ctx->inflight_wait, &wait);
|
finish_wait(&ctx->inflight_wait, &wait);
|
||||||
|
|
Loading…
Reference in New Issue