[SCSI] sd: Fix parsing of 'temporary ' cache mode prefix

Commit 39c60a0948 '[SCSI] sd: fix array cache flushing bug causing
performance problems' added temp as a pointer to "temporary " and used
sizeof(temp) - 1 as its length.  But sizeof(temp) is the size of the
pointer, not the size of the string constant.  Change temp to a static
array so that sizeof() does what was intended.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: stable@vger.kernel.org
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
This commit is contained in:
Ben Hutchings 2013-05-27 19:07:19 +01:00 committed by James Bottomley
parent c6e23d83c3
commit 2ee3e26c67
1 changed files with 1 additions and 1 deletions

View File

@ -142,7 +142,7 @@ sd_store_cache_type(struct device *dev, struct device_attribute *attr,
char *buffer_data;
struct scsi_mode_data data;
struct scsi_sense_hdr sshdr;
const char *temp = "temporary ";
static const char temp[] = "temporary ";
int len;
if (sdp->type != TYPE_DISK)