hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

selftests/exec: include cwd in long path calculation 

When creating a pathname close to PATH_MAX to test execveat, factor in
the current working directory path otherwise we end up with an absolute
path that is longer than PATH_MAX. While execveat() may succeed, subsequent
calls to the kernel from the runtime environment which are required to
successfully execute the test binary/script may fail because of this.

To keep the semantics of the test the same, rework the relative pathname
part of the test to be relative to the root directory so it isn't
decreased by the length of the current working directory path.

Signed-off-by: Steve Muckle <smuckle.linux@gmail.com>
Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
This commit is contained in:
Steve Muckle 2017-10-12 21:44:57 -07:00 committed by Shuah Khan
parent d54e9a8f44
commit 2d80c92d6c
1 changed files with 19 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
tools/testing/selftests/exec/execveat.c
View File

@ -147,7 +147,7 @@ static void exe_cp(const char *src, const char *dest)
} }
#define XX_DIR_LEN 200 #define XX_DIR_LEN 200
static int check_execveat_pathmax(int dot_dfd, const char *src, int is_script) static int check_execveat_pathmax(int root_dfd, const char *src, int is_script)
{ {
int fail = 0; int fail = 0;
int ii, count, len; int ii, count, len;
@ -156,20 +156,30 @@ static int check_execveat_pathmax(int dot_dfd, const char *src, int is_script)
if (*longpath == '\0') { if (*longpath == '\0') {
/* Create a filename close to PATH_MAX in length */ /* Create a filename close to PATH_MAX in length */
char *cwd = getcwd(NULL, 0);
if (!cwd) {
printf("Failed to getcwd(), errno=%d (%s)\n",
errno, strerror(errno));
return 2;
}
strcpy(longpath, cwd);
strcat(longpath, "/");
memset(longname, 'x', XX_DIR_LEN - 1); memset(longname, 'x', XX_DIR_LEN - 1);
longname[XX_DIR_LEN - 1] = '/'; longname[XX_DIR_LEN - 1] = '/';
longname[XX_DIR_LEN] = '\0'; longname[XX_DIR_LEN] = '\0';
count = (PATH_MAX - 3) / XX_DIR_LEN; count = (PATH_MAX - 3 - strlen(cwd)) / XX_DIR_LEN;
for (ii = 0; ii < count; ii++) { for (ii = 0; ii < count; ii++) {
strcat(longpath, longname); strcat(longpath, longname);
mkdir(longpath, 0755); mkdir(longpath, 0755);
} }
len = (PATH_MAX - 3) - (count * XX_DIR_LEN); len = (PATH_MAX - 3 - strlen(cwd)) - (count * XX_DIR_LEN);
if (len <= 0) if (len <= 0)
len = 1; len = 1;
memset(longname, 'y', len); memset(longname, 'y', len);
longname[len] = '\0'; longname[len] = '\0';
strcat(longpath, longname); strcat(longpath, longname);
free(cwd);
} }
exe_cp(src, longpath); exe_cp(src, longpath);
@ -190,7 +200,7 @@ static int check_execveat_pathmax(int dot_dfd, const char *src, int is_script)
} }
/* /*
* Execute as a long pathname relative to ".". If this is a script, * Execute as a long pathname relative to "/". If this is a script,
* the interpreter will launch but fail to open the script because its * the interpreter will launch but fail to open the script because its
* name ("/dev/fd/5/xxx....") is bigger than PATH_MAX. * name ("/dev/fd/5/xxx....") is bigger than PATH_MAX.
* *
@ -200,10 +210,10 @@ static int check_execveat_pathmax(int dot_dfd, const char *src, int is_script)
* the exit status shall be 126."), so allow either. * the exit status shall be 126."), so allow either.
*/ */
if (is_script) if (is_script)
fail += check_execveat_invoked_rc(dot_dfd, longpath, 0, fail += check_execveat_invoked_rc(root_dfd, longpath + 1, 0,
127, 126); 127, 126);
else else
fail += check_execveat(dot_dfd, longpath, 0); fail += check_execveat(root_dfd, longpath + 1, 0);
return fail; return fail;
} }
@ -218,6 +228,7 @@ static int run_tests(void)
int subdir_dfd_ephemeral = open_or_die("subdir.ephemeral", int subdir_dfd_ephemeral = open_or_die("subdir.ephemeral",
O_DIRECTORY|O_RDONLY); O_DIRECTORY|O_RDONLY);
int dot_dfd = open_or_die(".", O_DIRECTORY|O_RDONLY); int dot_dfd = open_or_die(".", O_DIRECTORY|O_RDONLY);
int root_dfd = open_or_die("/", O_DIRECTORY|O_RDONLY);
int dot_dfd_path = open_or_die(".", O_DIRECTORY|O_RDONLY|O_PATH); int dot_dfd_path = open_or_die(".", O_DIRECTORY|O_RDONLY|O_PATH);
int dot_dfd_cloexec = open_or_die(".", O_DIRECTORY|O_RDONLY|O_CLOEXEC); int dot_dfd_cloexec = open_or_die(".", O_DIRECTORY|O_RDONLY|O_CLOEXEC);
int fd = open_or_die("execveat", O_RDONLY); int fd = open_or_die("execveat", O_RDONLY);
@ -353,8 +364,8 @@ static int run_tests(void)
/* Attempt to execute relative to non-directory => ENOTDIR */ /* Attempt to execute relative to non-directory => ENOTDIR */
fail += check_execveat_fail(fd, "execveat", 0, ENOTDIR); fail += check_execveat_fail(fd, "execveat", 0, ENOTDIR);
fail += check_execveat_pathmax(dot_dfd, "execveat", 0); fail += check_execveat_pathmax(root_dfd, "execveat", 0);
fail += check_execveat_pathmax(dot_dfd, "script", 1); fail += check_execveat_pathmax(root_dfd, "script", 1);
return fail; return fail;
} }