rcuscale: Provide clear error when async specified without primitives
[ Upstream commit 11377947b5
]
Currently, if the rcuscale module's async module parameter is specified
for RCU implementations that do not have async primitives such as RCU
Tasks Rude (which now lacks a call_rcu_tasks_rude() function), there
will be a series of splats due to calls to a NULL pointer. This commit
therefore warns of this situation, but switches to non-async testing.
Signed-off-by: "Paul E. McKenney" <paulmck@kernel.org>
Signed-off-by: Neeraj Upadhyay <neeraj.upadhyay@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
fdda354f60
commit
2d56271fce
|
@ -498,7 +498,7 @@ rcu_scale_writer(void *arg)
|
||||||
schedule_timeout_idle(torture_random(&tr) % writer_holdoff_jiffies + 1);
|
schedule_timeout_idle(torture_random(&tr) % writer_holdoff_jiffies + 1);
|
||||||
wdp = &wdpp[i];
|
wdp = &wdpp[i];
|
||||||
*wdp = ktime_get_mono_fast_ns();
|
*wdp = ktime_get_mono_fast_ns();
|
||||||
if (gp_async) {
|
if (gp_async && !WARN_ON_ONCE(!cur_ops->async)) {
|
||||||
retry:
|
retry:
|
||||||
if (!rhp)
|
if (!rhp)
|
||||||
rhp = kmalloc(sizeof(*rhp), GFP_KERNEL);
|
rhp = kmalloc(sizeof(*rhp), GFP_KERNEL);
|
||||||
|
@ -554,7 +554,7 @@ retry:
|
||||||
i++;
|
i++;
|
||||||
rcu_scale_wait_shutdown();
|
rcu_scale_wait_shutdown();
|
||||||
} while (!torture_must_stop());
|
} while (!torture_must_stop());
|
||||||
if (gp_async) {
|
if (gp_async && cur_ops->async) {
|
||||||
cur_ops->gp_barrier();
|
cur_ops->gp_barrier();
|
||||||
}
|
}
|
||||||
writer_n_durations[me] = i_max + 1;
|
writer_n_durations[me] = i_max + 1;
|
||||||
|
|
Loading…
Reference in New Issue