hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

drivers: firmware: psci: make two helper functions inline 

The previous patch marked these two as 'static' which showed that they
are sometimes unused:

drivers/firmware/psci.c:103:13: error: 'psci_power_state_is_valid' defined but not used [-Werror=unused-function]
 static bool psci_power_state_is_valid(u32 state)
drivers/firmware/psci.c:94:13: error: 'psci_power_state_loses_context' defined but not used [-Werror=unused-function]
 static bool psci_power_state_loses_context(u32 state)

This also marks the functions 'inline', which has the main effect of
silently ignoring them when they are unused. The compiler will typically
inline small static functions anyway, so this seems more appropriate
than using __maybe_unused, which would have the same result otherwise.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 21e8868 ("drivers: firmware: psci: make two helper functions static")
This commit is contained in:
Arnd Bergmann 2016-04-26 02:13:30 +02:00
parent c5f9d6b137
commit 2b9cf18982
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/firmware/psci.c
View File

@ -91,7 +91,7 @@ static inline bool psci_has_ext_power_state(void)
PSCI_1_0_FEATURES_CPU_SUSPEND_PF_MASK; PSCI_1_0_FEATURES_CPU_SUSPEND_PF_MASK;
} }
static bool psci_power_state_loses_context(u32 state) static inline bool psci_power_state_loses_context(u32 state)
{ {
const u32 mask = psci_has_ext_power_state() ? const u32 mask = psci_has_ext_power_state() ?
PSCI_1_0_EXT_POWER_STATE_TYPE_MASK : PSCI_1_0_EXT_POWER_STATE_TYPE_MASK :
@ -100,7 +100,7 @@ static bool psci_power_state_loses_context(u32 state)
return state & mask; return state & mask;
} }
static bool psci_power_state_is_valid(u32 state) static inline bool psci_power_state_is_valid(u32 state)
{ {
const u32 valid_mask = psci_has_ext_power_state() ? const u32 valid_mask = psci_has_ext_power_state() ?
PSCI_1_0_EXT_POWER_STATE_MASK : PSCI_1_0_EXT_POWER_STATE_MASK :