VIDEO: Correct use of request_region/request_mem_region
request_region should be used with release_region, not request_mem_region. Geert Uytterhoeven pointed out that in the case of drivers/video/gbefb.c, the problem is actually the other way around; request_mem_region should be used instead of request_region. The semantic patch that finds/fixes this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r1@ expression start; @@ request_region(start,...) @b1@ expression r1.start; @@ request_mem_region(start,...) @depends on !b1@ expression r1.start; expression E; @@ - release_mem_region + release_region (start,E) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
This commit is contained in:
parent
9fe6206f40
commit
26692f53ef
|
@ -1571,8 +1571,8 @@ out_err_iobase:
|
|||
if (default_par->mtrr_handle >= 0)
|
||||
mtrr_del(default_par->mtrr_handle, info->fix.smem_start,
|
||||
info->fix.smem_len);
|
||||
release_mem_region(pci_resource_start(pdev, 2),
|
||||
pci_resource_len(pdev, 2));
|
||||
release_region(pci_resource_start(pdev, 2),
|
||||
pci_resource_len(pdev, 2));
|
||||
out_err_screenbase:
|
||||
if (info->screen_base)
|
||||
iounmap(info->screen_base);
|
||||
|
|
Loading…
Reference in New Issue