hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

drm/msm: Deletion of unnecessary checks before two function calls 

The functions framebuffer_release() and vunmap() perform also input
parameter validation. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Rob Clark <robdclark@gmail.com>
This commit is contained in:
Markus Elfring 2014-11-25 14:30:28 +01:00 committed by Rob Clark
parent 4e0cd68115
commit 264f7d673f
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/gpu/drm/msm/msm_fbdev.c
View File

@ -190,8 +190,7 @@ fail_unlock:
fail: fail:
if (ret) { if (ret) {
if (fbi) framebuffer_release(fbi);
framebuffer_release(fbi);
if (fb) { if (fb) {
drm_framebuffer_unregister_private(fb); drm_framebuffer_unregister_private(fb);
drm_framebuffer_remove(fb); drm_framebuffer_remove(fb);

3
drivers/gpu/drm/msm/msm_gem.c
View File

@ -535,8 +535,7 @@ void msm_gem_free_object(struct drm_gem_object *obj)
drm_free_large(msm_obj->pages); drm_free_large(msm_obj->pages);
} else { } else {
if (msm_obj->vaddr) vunmap(msm_obj->vaddr);
vunmap(msm_obj->vaddr);
put_pages(obj); put_pages(obj);
} }