nbd: restructure sock_shutdown

This patch restructures sock_shutdown to avoid having the main code path
in an if block.

Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Jens Axboe <axboe@fb.com>
This commit is contained in:
Markus Pargmann 2015-08-17 08:20:02 +02:00 committed by Jens Axboe
parent 36e47bee7c
commit 260bbce403
1 changed files with 7 additions and 6 deletions

View File

@ -119,12 +119,13 @@ static void nbd_end_request(struct nbd_device *nbd, struct request *req)
*/ */
static void sock_shutdown(struct nbd_device *nbd) static void sock_shutdown(struct nbd_device *nbd)
{ {
if (nbd->sock) { if (!nbd->sock)
dev_warn(disk_to_dev(nbd->disk), "shutting down socket\n"); return;
kernel_sock_shutdown(nbd->sock, SHUT_RDWR);
nbd->sock = NULL; dev_warn(disk_to_dev(nbd->disk), "shutting down socket\n");
del_timer_sync(&nbd->timeout_timer); kernel_sock_shutdown(nbd->sock, SHUT_RDWR);
} nbd->sock = NULL;
del_timer_sync(&nbd->timeout_timer);
} }
static void nbd_xmit_timeout(unsigned long arg) static void nbd_xmit_timeout(unsigned long arg)