hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[media] ddbridge: Do not free_irq() if request_irq() failed 

My static checker detected that free_irq() is called even after
request_irq() failed in ddb_probe(). In this case, the kernel may try to
free dev->pdev->irq although the IRQ is not assigned. This event rarely
occurs, but always introduces a warning if it happens.

"goto fail1" always results in disabling enabled MSI and releasing a
requested IRQ. It seems like the former handling is necessary. So I added
a conditional branch before the free_irq() (stat == 0 means request_irq()
succeeds).

Signed-off-by: Takeshi Yoshimura <yos@sslab.ics.keio.ac.jp>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
This commit is contained in:
Takeshi Yoshimura 2015-05-27 11:28:14 -03:00 committed by Mauro Carvalho Chehab
parent ee8defecea
commit 25e057fdde
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/media/pci/ddbridge/ddbridge-core.c
View File

@ -1630,7 +1630,8 @@ fail1:
printk(KERN_ERR "fail1\n"); printk(KERN_ERR "fail1\n");
if (dev->msi) if (dev->msi)
pci_disable_msi(dev->pdev); pci_disable_msi(dev->pdev);
free_irq(dev->pdev->irq, dev); if (stat == 0)
free_irq(dev->pdev->irq, dev);
fail: fail:
printk(KERN_ERR "fail\n"); printk(KERN_ERR "fail\n");
ddb_unmap(dev); ddb_unmap(dev);