hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

PM / devfreq: fix missing check of return value in devfreq_add_device() 

devm_kzalloc() could fail, so insert a check of its return value. And
if it fails, returns -ENOMEM.

Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
This commit is contained in:
Yangtao Li 2019-01-19 11:04:53 -05:00 committed by MyungJoo Ham
parent a9487917ba
commit 25846fa1ce
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/devfreq/devfreq.c
View File

@ -689,10 +689,22 @@ struct devfreq *devfreq_add_device(struct device *dev,
devfreq->profile->max_state, devfreq->profile->max_state,
devfreq->profile->max_state), devfreq->profile->max_state),
GFP_KERNEL); GFP_KERNEL);
if (!devfreq->trans_table) {
mutex_unlock(&devfreq->lock);
err = -ENOMEM;
goto err_devfreq;
}
devfreq->time_in_state = devm_kcalloc(&devfreq->dev, devfreq->time_in_state = devm_kcalloc(&devfreq->dev,
devfreq->profile->max_state, devfreq->profile->max_state,
sizeof(unsigned long), sizeof(unsigned long),
GFP_KERNEL); GFP_KERNEL);
if (!devfreq->time_in_state) {
mutex_unlock(&devfreq->lock);
err = -ENOMEM;
goto err_devfreq;
}
devfreq->last_stat_updated = jiffies; devfreq->last_stat_updated = jiffies;
srcu_init_notifier_head(&devfreq->transition_notifier_list); srcu_init_notifier_head(&devfreq->transition_notifier_list);
@ -726,7 +738,7 @@ struct devfreq *devfreq_add_device(struct device *dev,
err_init: err_init:
mutex_unlock(&devfreq_list_lock); mutex_unlock(&devfreq_list_lock);
err_devfreq:
devfreq_remove_device(devfreq); devfreq_remove_device(devfreq);
devfreq = NULL; devfreq = NULL;
err_dev: err_dev: