IB/core: Pass hardware specific data in query_device

Vendors should be able to pass vendor specific data to/from
user-space via query_device uverb. In order to do this,
we need to pass the vendors' specific udata.

Signed-off-by: Matan Barak <matanb@mellanox.com>
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
This commit is contained in:
Matan Barak 2015-06-11 16:35:25 +03:00 committed by Doug Ledford
parent 24306dc661
commit 2528e33e68
18 changed files with 75 additions and 25 deletions

View File

@ -539,9 +539,11 @@ EXPORT_SYMBOL(ib_dispatch_event);
int ib_query_device(struct ib_device *device, int ib_query_device(struct ib_device *device,
struct ib_device_attr *device_attr) struct ib_device_attr *device_attr)
{ {
struct ib_udata uhw = {.outlen = 0, .inlen = 0};
memset(device_attr, 0, sizeof(*device_attr)); memset(device_attr, 0, sizeof(*device_attr));
return device->query_device(device, device_attr); return device->query_device(device, device_attr, &uhw);
} }
EXPORT_SYMBOL(ib_query_device); EXPORT_SYMBOL(ib_query_device);

View File

@ -3428,7 +3428,7 @@ int ib_uverbs_ex_query_device(struct ib_uverbs_file *file,
memset(&attr, 0, sizeof(attr)); memset(&attr, 0, sizeof(attr));
err = device->query_device(device, &attr); err = device->query_device(device, &attr, uhw);
if (err) if (err)
return err; return err;

View File

@ -63,13 +63,16 @@
#include "c2_provider.h" #include "c2_provider.h"
#include "c2_user.h" #include "c2_user.h"
static int c2_query_device(struct ib_device *ibdev, static int c2_query_device(struct ib_device *ibdev, struct ib_device_attr *props,
struct ib_device_attr *props) struct ib_udata *uhw)
{ {
struct c2_dev *c2dev = to_c2dev(ibdev); struct c2_dev *c2dev = to_c2dev(ibdev);
pr_debug("%s:%u\n", __func__, __LINE__); pr_debug("%s:%u\n", __func__, __LINE__);
if (uhw->inlen || uhw->outlen)
return -EINVAL;
*props = c2dev->props; *props = c2dev->props;
return 0; return 0;
} }

View File

@ -1150,13 +1150,17 @@ static u64 fw_vers_string_to_u64(struct iwch_dev *iwch_dev)
(fw_mic & 0xffff); (fw_mic & 0xffff);
} }
static int iwch_query_device(struct ib_device *ibdev, static int iwch_query_device(struct ib_device *ibdev, struct ib_device_attr *props,
struct ib_device_attr *props) struct ib_udata *uhw)
{ {
struct iwch_dev *dev; struct iwch_dev *dev;
PDBG("%s ibdev %p\n", __func__, ibdev); PDBG("%s ibdev %p\n", __func__, ibdev);
if (uhw->inlen || uhw->outlen)
return -EINVAL;
dev = to_iwch_dev(ibdev); dev = to_iwch_dev(ibdev);
memset(props, 0, sizeof *props); memset(props, 0, sizeof *props);
memcpy(&props->sys_image_guid, dev->rdev.t3cdev_p->lldev->dev_addr, 6); memcpy(&props->sys_image_guid, dev->rdev.t3cdev_p->lldev->dev_addr, 6);

View File

@ -302,13 +302,17 @@ static int c4iw_query_gid(struct ib_device *ibdev, u8 port, int index,
return 0; return 0;
} }
static int c4iw_query_device(struct ib_device *ibdev, static int c4iw_query_device(struct ib_device *ibdev, struct ib_device_attr *props,
struct ib_device_attr *props) struct ib_udata *uhw)
{ {
struct c4iw_dev *dev; struct c4iw_dev *dev;
PDBG("%s ibdev %p\n", __func__, ibdev); PDBG("%s ibdev %p\n", __func__, ibdev);
if (uhw->inlen || uhw->outlen)
return -EINVAL;
dev = to_c4iw_dev(ibdev); dev = to_c4iw_dev(ibdev);
memset(props, 0, sizeof *props); memset(props, 0, sizeof *props);
memcpy(&props->sys_image_guid, dev->rdev.lldi.ports[0]->dev_addr, 6); memcpy(&props->sys_image_guid, dev->rdev.lldi.ports[0]->dev_addr, 6);

View File

@ -50,7 +50,8 @@ static unsigned int limit_uint(unsigned int value)
return min_t(unsigned int, value, INT_MAX); return min_t(unsigned int, value, INT_MAX);
} }
int ehca_query_device(struct ib_device *ibdev, struct ib_device_attr *props) int ehca_query_device(struct ib_device *ibdev, struct ib_device_attr *props,
struct ib_udata *uhw)
{ {
int i, ret = 0; int i, ret = 0;
struct ehca_shca *shca = container_of(ibdev, struct ehca_shca, struct ehca_shca *shca = container_of(ibdev, struct ehca_shca,
@ -71,6 +72,9 @@ int ehca_query_device(struct ib_device *ibdev, struct ib_device_attr *props)
IB_DEVICE_PORT_ACTIVE_EVENT, HCA_CAP_PORT_ACTIVE_EVENT, IB_DEVICE_PORT_ACTIVE_EVENT, HCA_CAP_PORT_ACTIVE_EVENT,
}; };
if (uhw->inlen || uhw->outlen)
return -EINVAL;
rblock = ehca_alloc_fw_ctrlblock(GFP_KERNEL); rblock = ehca_alloc_fw_ctrlblock(GFP_KERNEL);
if (!rblock) { if (!rblock) {
ehca_err(&shca->ib_device, "Can't allocate rblock memory."); ehca_err(&shca->ib_device, "Can't allocate rblock memory.");

View File

@ -44,7 +44,8 @@
#include "ehca_classes.h" #include "ehca_classes.h"
int ehca_query_device(struct ib_device *ibdev, struct ib_device_attr *props); int ehca_query_device(struct ib_device *ibdev, struct ib_device_attr *props,
struct ib_udata *uhw);
int ehca_query_port(struct ib_device *ibdev, u8 port, int ehca_query_port(struct ib_device *ibdev, u8 port,
struct ib_port_attr *props); struct ib_port_attr *props);

View File

@ -1495,11 +1495,14 @@ bail:
return 0; return 0;
} }
static int ipath_query_device(struct ib_device *ibdev, static int ipath_query_device(struct ib_device *ibdev, struct ib_device_attr *props,
struct ib_device_attr *props) struct ib_udata *uhw)
{ {
struct ipath_ibdev *dev = to_idev(ibdev); struct ipath_ibdev *dev = to_idev(ibdev);
if (uhw->inlen || uhw->outlen)
return -EINVAL;
memset(props, 0, sizeof(*props)); memset(props, 0, sizeof(*props));
props->device_cap_flags = IB_DEVICE_BAD_PKEY_CNTR | props->device_cap_flags = IB_DEVICE_BAD_PKEY_CNTR |

View File

@ -132,7 +132,8 @@ static int num_ib_ports(struct mlx4_dev *dev)
} }
static int mlx4_ib_query_device(struct ib_device *ibdev, static int mlx4_ib_query_device(struct ib_device *ibdev,
struct ib_device_attr *props) struct ib_device_attr *props,
struct ib_udata *uhw)
{ {
struct mlx4_ib_dev *dev = to_mdev(ibdev); struct mlx4_ib_dev *dev = to_mdev(ibdev);
struct ib_smp *in_mad = NULL; struct ib_smp *in_mad = NULL;
@ -140,6 +141,9 @@ static int mlx4_ib_query_device(struct ib_device *ibdev,
int err = -ENOMEM; int err = -ENOMEM;
int have_ib_ports; int have_ib_ports;
if (uhw->inlen || uhw->outlen)
return -EINVAL;
in_mad = kzalloc(sizeof *in_mad, GFP_KERNEL); in_mad = kzalloc(sizeof *in_mad, GFP_KERNEL);
out_mad = kmalloc(sizeof *out_mad, GFP_KERNEL); out_mad = kmalloc(sizeof *out_mad, GFP_KERNEL);
if (!in_mad || !out_mad) if (!in_mad || !out_mad)

View File

@ -63,7 +63,8 @@ static char mlx5_version[] =
DRIVER_VERSION " (" DRIVER_RELDATE ")\n"; DRIVER_VERSION " (" DRIVER_RELDATE ")\n";
static int mlx5_ib_query_device(struct ib_device *ibdev, static int mlx5_ib_query_device(struct ib_device *ibdev,
struct ib_device_attr *props) struct ib_device_attr *props,
struct ib_udata *uhw)
{ {
struct mlx5_ib_dev *dev = to_mdev(ibdev); struct mlx5_ib_dev *dev = to_mdev(ibdev);
struct ib_smp *in_mad = NULL; struct ib_smp *in_mad = NULL;
@ -74,6 +75,9 @@ static int mlx5_ib_query_device(struct ib_device *ibdev,
int max_sq_sg; int max_sq_sg;
u64 flags; u64 flags;
if (uhw->inlen || uhw->outlen)
return -EINVAL;
gen = &dev->mdev->caps.gen; gen = &dev->mdev->caps.gen;
in_mad = kzalloc(sizeof(*in_mad), GFP_KERNEL); in_mad = kzalloc(sizeof(*in_mad), GFP_KERNEL);
out_mad = kmalloc(sizeof(*out_mad), GFP_KERNEL); out_mad = kmalloc(sizeof(*out_mad), GFP_KERNEL);
@ -910,6 +914,7 @@ static int get_port_caps(struct mlx5_ib_dev *dev)
struct mlx5_general_caps *gen; struct mlx5_general_caps *gen;
int err = -ENOMEM; int err = -ENOMEM;
int port; int port;
struct ib_udata uhw = {.inlen = 0, .outlen = 0};
gen = &dev->mdev->caps.gen; gen = &dev->mdev->caps.gen;
pprops = kmalloc(sizeof(*pprops), GFP_KERNEL); pprops = kmalloc(sizeof(*pprops), GFP_KERNEL);
@ -920,7 +925,7 @@ static int get_port_caps(struct mlx5_ib_dev *dev)
if (!dprops) if (!dprops)
goto out; goto out;
err = mlx5_ib_query_device(&dev->ib_dev, dprops); err = mlx5_ib_query_device(&dev->ib_dev, dprops, &uhw);
if (err) { if (err) {
mlx5_ib_warn(dev, "query_device failed %d\n", err); mlx5_ib_warn(dev, "query_device failed %d\n", err);
goto out; goto out;

View File

@ -57,14 +57,17 @@ static void init_query_mad(struct ib_smp *mad)
mad->method = IB_MGMT_METHOD_GET; mad->method = IB_MGMT_METHOD_GET;
} }
static int mthca_query_device(struct ib_device *ibdev, static int mthca_query_device(struct ib_device *ibdev, struct ib_device_attr *props,
struct ib_device_attr *props) struct ib_udata *uhw)
{ {
struct ib_smp *in_mad = NULL; struct ib_smp *in_mad = NULL;
struct ib_smp *out_mad = NULL; struct ib_smp *out_mad = NULL;
int err = -ENOMEM; int err = -ENOMEM;
struct mthca_dev *mdev = to_mdev(ibdev); struct mthca_dev *mdev = to_mdev(ibdev);
if (uhw->inlen || uhw->outlen)
return -EINVAL;
in_mad = kzalloc(sizeof *in_mad, GFP_KERNEL); in_mad = kzalloc(sizeof *in_mad, GFP_KERNEL);
out_mad = kmalloc(sizeof *out_mad, GFP_KERNEL); out_mad = kmalloc(sizeof *out_mad, GFP_KERNEL);
if (!in_mad || !out_mad) if (!in_mad || !out_mad)

View File

@ -512,12 +512,16 @@ static void nes_free_fast_reg_page_list(struct ib_fast_reg_page_list *pifrpl)
/** /**
* nes_query_device * nes_query_device
*/ */
static int nes_query_device(struct ib_device *ibdev, struct ib_device_attr *props) static int nes_query_device(struct ib_device *ibdev, struct ib_device_attr *props,
struct ib_udata *uhw)
{ {
struct nes_vnic *nesvnic = to_nesvnic(ibdev); struct nes_vnic *nesvnic = to_nesvnic(ibdev);
struct nes_device *nesdev = nesvnic->nesdev; struct nes_device *nesdev = nesvnic->nesdev;
struct nes_ib_device *nesibdev = nesvnic->nesibdev; struct nes_ib_device *nesibdev = nesvnic->nesibdev;
if (uhw->inlen || uhw->outlen)
return -EINVAL;
memset(props, 0, sizeof(*props)); memset(props, 0, sizeof(*props));
memcpy(&props->sys_image_guid, nesvnic->netdev->dev_addr, 6); memcpy(&props->sys_image_guid, nesvnic->netdev->dev_addr, 6);

View File

@ -61,10 +61,14 @@ int ocrdma_query_gid(struct ib_device *ibdev, u8 port,
return 0; return 0;
} }
int ocrdma_query_device(struct ib_device *ibdev, struct ib_device_attr *attr) int ocrdma_query_device(struct ib_device *ibdev, struct ib_device_attr *attr,
struct ib_udata *uhw)
{ {
struct ocrdma_dev *dev = get_ocrdma_dev(ibdev); struct ocrdma_dev *dev = get_ocrdma_dev(ibdev);
if (uhw->inlen || uhw->outlen)
return -EINVAL;
memset(attr, 0, sizeof *attr); memset(attr, 0, sizeof *attr);
memcpy(&attr->fw_ver, &dev->attr.fw_ver[0], memcpy(&attr->fw_ver, &dev->attr.fw_ver[0],
min(sizeof(dev->attr.fw_ver), sizeof(attr->fw_ver))); min(sizeof(dev->attr.fw_ver), sizeof(attr->fw_ver)));

View File

@ -36,7 +36,8 @@ int ocrdma_post_recv(struct ib_qp *, struct ib_recv_wr *,
int ocrdma_poll_cq(struct ib_cq *, int num_entries, struct ib_wc *wc); int ocrdma_poll_cq(struct ib_cq *, int num_entries, struct ib_wc *wc);
int ocrdma_arm_cq(struct ib_cq *, enum ib_cq_notify_flags flags); int ocrdma_arm_cq(struct ib_cq *, enum ib_cq_notify_flags flags);
int ocrdma_query_device(struct ib_device *, struct ib_device_attr *props); int ocrdma_query_device(struct ib_device *, struct ib_device_attr *props,
struct ib_udata *uhw);
int ocrdma_query_port(struct ib_device *, u8 port, struct ib_port_attr *props); int ocrdma_query_port(struct ib_device *, u8 port, struct ib_port_attr *props);
int ocrdma_modify_port(struct ib_device *, u8 port, int mask, int ocrdma_modify_port(struct ib_device *, u8 port, int mask,
struct ib_port_modify *props); struct ib_port_modify *props);

View File

@ -1550,12 +1550,14 @@ full:
} }
} }
static int qib_query_device(struct ib_device *ibdev, static int qib_query_device(struct ib_device *ibdev, struct ib_device_attr *props,
struct ib_device_attr *props) struct ib_udata *uhw)
{ {
struct qib_devdata *dd = dd_from_ibdev(ibdev); struct qib_devdata *dd = dd_from_ibdev(ibdev);
struct qib_ibdev *dev = to_idev(ibdev); struct qib_ibdev *dev = to_idev(ibdev);
if (uhw->inlen || uhw->outlen)
return -EINVAL;
memset(props, 0, sizeof(*props)); memset(props, 0, sizeof(*props));
props->device_cap_flags = IB_DEVICE_BAD_PKEY_CNTR | props->device_cap_flags = IB_DEVICE_BAD_PKEY_CNTR |

View File

@ -248,7 +248,8 @@ enum rdma_link_layer usnic_ib_port_link_layer(struct ib_device *device,
} }
int usnic_ib_query_device(struct ib_device *ibdev, int usnic_ib_query_device(struct ib_device *ibdev,
struct ib_device_attr *props) struct ib_device_attr *props,
struct ib_udata *uhw)
{ {
struct usnic_ib_dev *us_ibdev = to_usdev(ibdev); struct usnic_ib_dev *us_ibdev = to_usdev(ibdev);
union ib_gid gid; union ib_gid gid;
@ -257,6 +258,9 @@ int usnic_ib_query_device(struct ib_device *ibdev,
int qp_per_vf; int qp_per_vf;
usnic_dbg("\n"); usnic_dbg("\n");
if (uhw->inlen || uhw->outlen)
return -EINVAL;
mutex_lock(&us_ibdev->usdev_lock); mutex_lock(&us_ibdev->usdev_lock);
us_ibdev->netdev->ethtool_ops->get_drvinfo(us_ibdev->netdev, &info); us_ibdev->netdev->ethtool_ops->get_drvinfo(us_ibdev->netdev, &info);
us_ibdev->netdev->ethtool_ops->get_settings(us_ibdev->netdev, &cmd); us_ibdev->netdev->ethtool_ops->get_settings(us_ibdev->netdev, &cmd);

View File

@ -24,7 +24,8 @@
enum rdma_link_layer usnic_ib_port_link_layer(struct ib_device *device, enum rdma_link_layer usnic_ib_port_link_layer(struct ib_device *device,
u8 port_num); u8 port_num);
int usnic_ib_query_device(struct ib_device *ibdev, int usnic_ib_query_device(struct ib_device *ibdev,
struct ib_device_attr *props); struct ib_device_attr *props,
struct ib_udata *uhw);
int usnic_ib_query_port(struct ib_device *ibdev, u8 port, int usnic_ib_query_port(struct ib_device *ibdev, u8 port,
struct ib_port_attr *props); struct ib_port_attr *props);
enum rdma_protocol_type enum rdma_protocol_type

View File

@ -1561,7 +1561,8 @@ struct ib_device {
int (*get_protocol_stats)(struct ib_device *device, int (*get_protocol_stats)(struct ib_device *device,
union rdma_protocol_stats *stats); union rdma_protocol_stats *stats);
int (*query_device)(struct ib_device *device, int (*query_device)(struct ib_device *device,
struct ib_device_attr *device_attr); struct ib_device_attr *device_attr,
struct ib_udata *udata);
int (*query_port)(struct ib_device *device, int (*query_port)(struct ib_device *device,
u8 port_num, u8 port_num,
struct ib_port_attr *port_attr); struct ib_port_attr *port_attr);