From 2301917044b96fda41f794011368e623a9b7a435 Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Tue, 8 May 2012 13:28:59 +0300 Subject: [PATCH] target: lock => unlock typo in transport_lun_wait_for_tasks target_stop_cmd() returns with the lock held and IRQs disabled. The intent was to unlock here. This bug was originally added with: commit cf572a9627c9ae86082216de109780c1d2e2ee28 Author: Christoph Hellwig Date: Tue Apr 24 00:25:05 2012 -0400 target: move the state and execute lists to the command Signed-off-by: Dan Carpenter Signed-off-by: Nicholas Bellinger --- drivers/target/target_core_transport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c index a10d7847f037..85f14e0fe5d3 100644 --- a/drivers/target/target_core_transport.c +++ b/drivers/target/target_core_transport.c @@ -3768,7 +3768,7 @@ static int transport_lun_wait_for_tasks(struct se_cmd *cmd, struct se_lun *lun) (cmd->transport_state & CMD_T_SENT)) { if (!target_stop_cmd(cmd, &flags)) ret++; - spin_lock_irqsave(&cmd->t_state_lock, flags); + spin_unlock_irqrestore(&cmd->t_state_lock, flags); } else { spin_unlock_irqrestore(&cmd->t_state_lock, flags);