hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

pinctrl: baytrail: fix some error handling in debugfs 

We need to unlock before continuing.  Also the continue was accidentally
left out on one error path which would lead to a NULL dereference.

Fixes: 86e3ef812f ('pinctrl: baytrail: Update gpio chip operations')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Dan Carpenter 2016-04-27 11:08:35 +03:00 committed by Linus Walleij
parent b5aa1006e4
commit 22bbd21b81
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/pinctrl/intel/pinctrl-baytrail.c
View File

@ -1390,6 +1390,7 @@ static void byt_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip)
seq_printf(s, seq_printf(s,
"Could not retrieve pin %i conf0 reg\n", "Could not retrieve pin %i conf0 reg\n",
pin); pin);
raw_spin_unlock_irqrestore(&vg->lock, flags);
continue; continue;
} }
conf0 = readl(reg); conf0 = readl(reg);
@ -1398,6 +1399,8 @@ static void byt_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip)
if (!reg) { if (!reg) {
seq_printf(s, seq_printf(s,
"Could not retrieve pin %i val reg\n", pin); "Could not retrieve pin %i val reg\n", pin);
raw_spin_unlock_irqrestore(&vg->lock, flags);
continue;
} }
val = readl(reg); val = readl(reg);
raw_spin_unlock_irqrestore(&vg->lock, flags); raw_spin_unlock_irqrestore(&vg->lock, flags);