powerpc/kprobes: Some cosmetic updates to try_to_emulate()

1. This is only used in kprobes.c, so make it static.
2. Remove the un-necessary (ret == 0) comparison in the else clause.

Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>
Reviewed-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
This commit is contained in:
Naveen N. Rao 2017-09-22 14:40:43 +05:30 committed by Michael Ellerman
parent c3dda4b0db
commit 22085337f5
1 changed files with 2 additions and 2 deletions

View File

@ -239,7 +239,7 @@ void arch_prepare_kretprobe(struct kretprobe_instance *ri, struct pt_regs *regs)
} }
NOKPROBE_SYMBOL(arch_prepare_kretprobe); NOKPROBE_SYMBOL(arch_prepare_kretprobe);
int try_to_emulate(struct kprobe *p, struct pt_regs *regs) static int try_to_emulate(struct kprobe *p, struct pt_regs *regs)
{ {
int ret; int ret;
unsigned int insn = *p->ainsn.insn; unsigned int insn = *p->ainsn.insn;
@ -261,7 +261,7 @@ int try_to_emulate(struct kprobe *p, struct pt_regs *regs)
*/ */
printk("Can't step on instruction %x\n", insn); printk("Can't step on instruction %x\n", insn);
BUG(); BUG();
} else if (ret == 0) } else
/* This instruction can't be boosted */ /* This instruction can't be boosted */
p->ainsn.boostable = -1; p->ainsn.boostable = -1;