ext4: fix wrong gfp type under transaction
This fixes the allocations with GFP_KERNEL while under a transaction problems in ext4. This patch is the same as its ext3 counterpart, just switches these to GFP_NOFS. Signed-off-by: Josef Bacik <jbacik@redhat.com> Cc: <linux-ext4@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Mingming Cao <cmm@us.ibm.com> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
This commit is contained in:
parent
2887df139c
commit
216553c4b7
|
@ -37,7 +37,7 @@ ext4_acl_from_disk(const void *value, size_t size)
|
|||
return ERR_PTR(-EINVAL);
|
||||
if (count == 0)
|
||||
return NULL;
|
||||
acl = posix_acl_alloc(count, GFP_KERNEL);
|
||||
acl = posix_acl_alloc(count, GFP_NOFS);
|
||||
if (!acl)
|
||||
return ERR_PTR(-ENOMEM);
|
||||
for (n=0; n < count; n++) {
|
||||
|
@ -91,7 +91,7 @@ ext4_acl_to_disk(const struct posix_acl *acl, size_t *size)
|
|||
|
||||
*size = ext4_acl_size(acl->a_count);
|
||||
ext_acl = kmalloc(sizeof(ext4_acl_header) + acl->a_count *
|
||||
sizeof(ext4_acl_entry), GFP_KERNEL);
|
||||
sizeof(ext4_acl_entry), GFP_NOFS);
|
||||
if (!ext_acl)
|
||||
return ERR_PTR(-ENOMEM);
|
||||
ext_acl->a_version = cpu_to_le32(EXT4_ACL_VERSION);
|
||||
|
@ -187,7 +187,7 @@ ext4_get_acl(struct inode *inode, int type)
|
|||
}
|
||||
retval = ext4_xattr_get(inode, name_index, "", NULL, 0);
|
||||
if (retval > 0) {
|
||||
value = kmalloc(retval, GFP_KERNEL);
|
||||
value = kmalloc(retval, GFP_NOFS);
|
||||
if (!value)
|
||||
return ERR_PTR(-ENOMEM);
|
||||
retval = ext4_xattr_get(inode, name_index, "", value, retval);
|
||||
|
@ -335,7 +335,7 @@ ext4_init_acl(handle_t *handle, struct inode *inode, struct inode *dir)
|
|||
if (error)
|
||||
goto cleanup;
|
||||
}
|
||||
clone = posix_acl_clone(acl, GFP_KERNEL);
|
||||
clone = posix_acl_clone(acl, GFP_NOFS);
|
||||
error = -ENOMEM;
|
||||
if (!clone)
|
||||
goto cleanup;
|
||||
|
|
|
@ -1977,7 +1977,7 @@ static int ext4_ext_remove_space(struct inode *inode, ext4_lblk_t start)
|
|||
* We start scanning from right side, freeing all the blocks
|
||||
* after i_size and walking into the tree depth-wise.
|
||||
*/
|
||||
path = kzalloc(sizeof(struct ext4_ext_path) * (depth + 1), GFP_KERNEL);
|
||||
path = kzalloc(sizeof(struct ext4_ext_path) * (depth + 1), GFP_NOFS);
|
||||
if (path == NULL) {
|
||||
ext4_journal_stop(handle);
|
||||
return -ENOMEM;
|
||||
|
|
|
@ -469,7 +469,7 @@ static int add_new_gdb(handle_t *handle, struct inode *inode,
|
|||
goto exit_dindj;
|
||||
|
||||
n_group_desc = kmalloc((gdb_num + 1) * sizeof(struct buffer_head *),
|
||||
GFP_KERNEL);
|
||||
GFP_NOFS);
|
||||
if (!n_group_desc) {
|
||||
err = -ENOMEM;
|
||||
ext4_warning(sb, __func__,
|
||||
|
@ -552,7 +552,7 @@ static int reserve_backup_gdb(handle_t *handle, struct inode *inode,
|
|||
int res, i;
|
||||
int err;
|
||||
|
||||
primary = kmalloc(reserved_gdb * sizeof(*primary), GFP_KERNEL);
|
||||
primary = kmalloc(reserved_gdb * sizeof(*primary), GFP_NOFS);
|
||||
if (!primary)
|
||||
return -ENOMEM;
|
||||
|
||||
|
|
|
@ -739,7 +739,7 @@ ext4_xattr_block_set(handle_t *handle, struct inode *inode,
|
|||
ce = NULL;
|
||||
}
|
||||
ea_bdebug(bs->bh, "cloning");
|
||||
s->base = kmalloc(bs->bh->b_size, GFP_KERNEL);
|
||||
s->base = kmalloc(bs->bh->b_size, GFP_NOFS);
|
||||
error = -ENOMEM;
|
||||
if (s->base == NULL)
|
||||
goto cleanup;
|
||||
|
@ -751,7 +751,7 @@ ext4_xattr_block_set(handle_t *handle, struct inode *inode,
|
|||
}
|
||||
} else {
|
||||
/* Allocate a buffer where we construct the new block. */
|
||||
s->base = kzalloc(sb->s_blocksize, GFP_KERNEL);
|
||||
s->base = kzalloc(sb->s_blocksize, GFP_NOFS);
|
||||
/* assert(header == s->base) */
|
||||
error = -ENOMEM;
|
||||
if (s->base == NULL)
|
||||
|
|
Loading…
Reference in New Issue