Revert commit 722f0b8911
("pNFS: Don't send COMMITs to the DSes if...")
Doing the test without taking any locks is racy, and so really it makes more sense to do it in the flexfiles code (which is the only case that cares). Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com> Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
This commit is contained in:
parent
4b75053e9b
commit
213297369c
|
@ -224,13 +224,6 @@ pnfs_generic_alloc_ds_commits(struct nfs_commit_info *cinfo,
|
||||||
for (i = 0; i < fl_cinfo->nbuckets; i++, bucket++) {
|
for (i = 0; i < fl_cinfo->nbuckets; i++, bucket++) {
|
||||||
if (list_empty(&bucket->committing))
|
if (list_empty(&bucket->committing))
|
||||||
continue;
|
continue;
|
||||||
/*
|
|
||||||
* If the layout segment is invalid, then let
|
|
||||||
* pnfs_generic_retry_commit() clean up the bucket.
|
|
||||||
*/
|
|
||||||
if (bucket->clseg && !pnfs_is_valid_lseg(bucket->clseg) &&
|
|
||||||
!test_bit(NFS_LSEG_LAYOUTRETURN, &bucket->clseg->pls_flags))
|
|
||||||
break;
|
|
||||||
data = nfs_commitdata_alloc(false);
|
data = nfs_commitdata_alloc(false);
|
||||||
if (!data)
|
if (!data)
|
||||||
break;
|
break;
|
||||||
|
|
Loading…
Reference in New Issue