hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Drivers: hv: vmbus: Properly protect calls to smp_processor_id() 

Disable preemption when sampling current processor ID when preemption
is otherwise possible.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Tested-by: Sitsofe Wheeler <sitsofe@yahoo.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
K. Y. Srinivasan 2014-08-28 18:29:53 -07:00 committed by Greg Kroah-Hartman
parent b29ef3546a
commit 2115b5617a
2 changed files with 20 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/hv/channel.c
View File

@ -486,11 +486,14 @@ static int vmbus_close_internal(struct vmbus_channel *channel)
channel->state = CHANNEL_OPEN_STATE; channel->state = CHANNEL_OPEN_STATE;
channel->sc_creation_callback = NULL; channel->sc_creation_callback = NULL;
/* Stop callback and cancel the timer asap */ /* Stop callback and cancel the timer asap */
if (channel->target_cpu != smp_processor_id()) if (channel->target_cpu != get_cpu()) {
put_cpu();
smp_call_function_single(channel->target_cpu, reset_channel_cb, smp_call_function_single(channel->target_cpu, reset_channel_cb,
channel, true); channel, true);
else } else {
reset_channel_cb(channel); reset_channel_cb(channel);
put_cpu();
}
/* Send a closing message */ /* Send a closing message */

21
drivers/hv/channel_mgmt.c
View File

@ -224,11 +224,14 @@ static void vmbus_process_rescind_offer(struct work_struct *work)
msg.header.msgtype = CHANNELMSG_RELID_RELEASED; msg.header.msgtype = CHANNELMSG_RELID_RELEASED;
vmbus_post_msg(&msg, sizeof(struct vmbus_channel_relid_released)); vmbus_post_msg(&msg, sizeof(struct vmbus_channel_relid_released));
if (channel->target_cpu != smp_processor_id()) if (channel->target_cpu != get_cpu()) {
put_cpu();
smp_call_function_single(channel->target_cpu, smp_call_function_single(channel->target_cpu,
percpu_channel_deq, channel, true); percpu_channel_deq, channel, true);
else } else {
percpu_channel_deq(channel); percpu_channel_deq(channel);
put_cpu();
}
if (channel->primary_channel == NULL) { if (channel->primary_channel == NULL) {
spin_lock_irqsave(&vmbus_connection.channel_lock, flags); spin_lock_irqsave(&vmbus_connection.channel_lock, flags);
@ -294,12 +297,15 @@ static void vmbus_process_offer(struct work_struct *work)
spin_unlock_irqrestore(&vmbus_connection.channel_lock, flags); spin_unlock_irqrestore(&vmbus_connection.channel_lock, flags);
if (enq) { if (enq) {
if (newchannel->target_cpu != smp_processor_id()) if (newchannel->target_cpu != get_cpu()) {
put_cpu();
smp_call_function_single(newchannel->target_cpu, smp_call_function_single(newchannel->target_cpu,
percpu_channel_enq, percpu_channel_enq,
newchannel, true); newchannel, true);
else } else {
percpu_channel_enq(newchannel); percpu_channel_enq(newchannel);
put_cpu();
}
} }
if (!fnew) { if (!fnew) {
/* /*
@ -314,12 +320,15 @@ static void vmbus_process_offer(struct work_struct *work)
list_add_tail(&newchannel->sc_list, &channel->sc_list); list_add_tail(&newchannel->sc_list, &channel->sc_list);
spin_unlock_irqrestore(&channel->sc_lock, flags); spin_unlock_irqrestore(&channel->sc_lock, flags);
if (newchannel->target_cpu != smp_processor_id()) if (newchannel->target_cpu != get_cpu()) {
put_cpu();
smp_call_function_single(newchannel->target_cpu, smp_call_function_single(newchannel->target_cpu,
percpu_channel_enq, percpu_channel_enq,
newchannel, true); newchannel, true);
else } else {
percpu_channel_enq(newchannel); percpu_channel_enq(newchannel);
put_cpu();
}
newchannel->state = CHANNEL_OPEN_STATE; newchannel->state = CHANNEL_OPEN_STATE;
if (channel->sc_creation_callback != NULL) if (channel->sc_creation_callback != NULL)