xfrm: Use separate low and high order bits of the sequence numbers in xfrm_skb_cb
To support IPsec extended sequence numbers, we split the output sequence numbers of xfrm_skb_cb in low and high order 32 bits and we add the high order 32 bits to the input sequence numbers. All users are updated accordingly. Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com> Acked-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
9736acf395
commit
1ce3644ade
|
@ -582,8 +582,14 @@ struct xfrm_skb_cb {
|
||||||
|
|
||||||
/* Sequence number for replay protection. */
|
/* Sequence number for replay protection. */
|
||||||
union {
|
union {
|
||||||
u64 output;
|
struct {
|
||||||
__be32 input;
|
__u32 low;
|
||||||
|
__u32 hi;
|
||||||
|
} output;
|
||||||
|
struct {
|
||||||
|
__be32 low;
|
||||||
|
__be32 hi;
|
||||||
|
} input;
|
||||||
} seq;
|
} seq;
|
||||||
};
|
};
|
||||||
|
|
||||||
|
|
|
@ -208,7 +208,7 @@ static int ah_output(struct xfrm_state *x, struct sk_buff *skb)
|
||||||
|
|
||||||
ah->reserved = 0;
|
ah->reserved = 0;
|
||||||
ah->spi = x->id.spi;
|
ah->spi = x->id.spi;
|
||||||
ah->seq_no = htonl(XFRM_SKB_CB(skb)->seq.output);
|
ah->seq_no = htonl(XFRM_SKB_CB(skb)->seq.output.low);
|
||||||
|
|
||||||
sg_init_table(sg, nfrags);
|
sg_init_table(sg, nfrags);
|
||||||
skb_to_sgvec(skb, sg, 0, skb->len);
|
skb_to_sgvec(skb, sg, 0, skb->len);
|
||||||
|
|
|
@ -215,7 +215,7 @@ static int esp_output(struct xfrm_state *x, struct sk_buff *skb)
|
||||||
}
|
}
|
||||||
|
|
||||||
esph->spi = x->id.spi;
|
esph->spi = x->id.spi;
|
||||||
esph->seq_no = htonl(XFRM_SKB_CB(skb)->seq.output);
|
esph->seq_no = htonl(XFRM_SKB_CB(skb)->seq.output.low);
|
||||||
|
|
||||||
sg_init_table(sg, nfrags);
|
sg_init_table(sg, nfrags);
|
||||||
skb_to_sgvec(skb, sg,
|
skb_to_sgvec(skb, sg,
|
||||||
|
@ -227,7 +227,7 @@ static int esp_output(struct xfrm_state *x, struct sk_buff *skb)
|
||||||
aead_givcrypt_set_crypt(req, sg, sg, clen, iv);
|
aead_givcrypt_set_crypt(req, sg, sg, clen, iv);
|
||||||
aead_givcrypt_set_assoc(req, asg, sizeof(*esph));
|
aead_givcrypt_set_assoc(req, asg, sizeof(*esph));
|
||||||
aead_givcrypt_set_giv(req, esph->enc_data,
|
aead_givcrypt_set_giv(req, esph->enc_data,
|
||||||
XFRM_SKB_CB(skb)->seq.output);
|
XFRM_SKB_CB(skb)->seq.output.low);
|
||||||
|
|
||||||
ESP_SKB_CB(skb)->tmp = tmp;
|
ESP_SKB_CB(skb)->tmp = tmp;
|
||||||
err = crypto_aead_givencrypt(req);
|
err = crypto_aead_givencrypt(req);
|
||||||
|
|
|
@ -409,7 +409,7 @@ static int ah6_output(struct xfrm_state *x, struct sk_buff *skb)
|
||||||
|
|
||||||
ah->reserved = 0;
|
ah->reserved = 0;
|
||||||
ah->spi = x->id.spi;
|
ah->spi = x->id.spi;
|
||||||
ah->seq_no = htonl(XFRM_SKB_CB(skb)->seq.output);
|
ah->seq_no = htonl(XFRM_SKB_CB(skb)->seq.output.low);
|
||||||
|
|
||||||
sg_init_table(sg, nfrags);
|
sg_init_table(sg, nfrags);
|
||||||
skb_to_sgvec(skb, sg, 0, skb->len);
|
skb_to_sgvec(skb, sg, 0, skb->len);
|
||||||
|
|
|
@ -204,7 +204,7 @@ static int esp6_output(struct xfrm_state *x, struct sk_buff *skb)
|
||||||
*skb_mac_header(skb) = IPPROTO_ESP;
|
*skb_mac_header(skb) = IPPROTO_ESP;
|
||||||
|
|
||||||
esph->spi = x->id.spi;
|
esph->spi = x->id.spi;
|
||||||
esph->seq_no = htonl(XFRM_SKB_CB(skb)->seq.output);
|
esph->seq_no = htonl(XFRM_SKB_CB(skb)->seq.output.low);
|
||||||
|
|
||||||
sg_init_table(sg, nfrags);
|
sg_init_table(sg, nfrags);
|
||||||
skb_to_sgvec(skb, sg,
|
skb_to_sgvec(skb, sg,
|
||||||
|
@ -216,7 +216,7 @@ static int esp6_output(struct xfrm_state *x, struct sk_buff *skb)
|
||||||
aead_givcrypt_set_crypt(req, sg, sg, clen, iv);
|
aead_givcrypt_set_crypt(req, sg, sg, clen, iv);
|
||||||
aead_givcrypt_set_assoc(req, asg, sizeof(*esph));
|
aead_givcrypt_set_assoc(req, asg, sizeof(*esph));
|
||||||
aead_givcrypt_set_giv(req, esph->enc_data,
|
aead_givcrypt_set_giv(req, esph->enc_data,
|
||||||
XFRM_SKB_CB(skb)->seq.output);
|
XFRM_SKB_CB(skb)->seq.output.low);
|
||||||
|
|
||||||
ESP_SKB_CB(skb)->tmp = tmp;
|
ESP_SKB_CB(skb)->tmp = tmp;
|
||||||
err = crypto_aead_givencrypt(req);
|
err = crypto_aead_givencrypt(req);
|
||||||
|
|
|
@ -118,7 +118,7 @@ int xfrm_input(struct sk_buff *skb, int nexthdr, __be32 spi, int encap_type)
|
||||||
if (encap_type < 0) {
|
if (encap_type < 0) {
|
||||||
async = 1;
|
async = 1;
|
||||||
x = xfrm_input_state(skb);
|
x = xfrm_input_state(skb);
|
||||||
seq = XFRM_SKB_CB(skb)->seq.input;
|
seq = XFRM_SKB_CB(skb)->seq.input.low;
|
||||||
goto resume;
|
goto resume;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -184,7 +184,7 @@ int xfrm_input(struct sk_buff *skb, int nexthdr, __be32 spi, int encap_type)
|
||||||
|
|
||||||
spin_unlock(&x->lock);
|
spin_unlock(&x->lock);
|
||||||
|
|
||||||
XFRM_SKB_CB(skb)->seq.input = seq;
|
XFRM_SKB_CB(skb)->seq.input.low = seq;
|
||||||
|
|
||||||
nexthdr = x->type->input(x, skb);
|
nexthdr = x->type->input(x, skb);
|
||||||
|
|
||||||
|
|
|
@ -68,7 +68,7 @@ static int xfrm_output_one(struct sk_buff *skb, int err)
|
||||||
}
|
}
|
||||||
|
|
||||||
if (x->type->flags & XFRM_TYPE_REPLAY_PROT) {
|
if (x->type->flags & XFRM_TYPE_REPLAY_PROT) {
|
||||||
XFRM_SKB_CB(skb)->seq.output = ++x->replay.oseq;
|
XFRM_SKB_CB(skb)->seq.output.low = ++x->replay.oseq;
|
||||||
if (unlikely(x->replay.oseq == 0)) {
|
if (unlikely(x->replay.oseq == 0)) {
|
||||||
XFRM_INC_STATS(net, LINUX_MIB_XFRMOUTSTATESEQERROR);
|
XFRM_INC_STATS(net, LINUX_MIB_XFRMOUTSTATESEQERROR);
|
||||||
x->replay.oseq--;
|
x->replay.oseq--;
|
||||||
|
|
Loading…
Reference in New Issue