[media] usb: constify vb2_ops structures
Check for vb2_ops structures that are only stored in the ops field of a vb2_queue structure. That field is declared const, so vb2_ops structures that have this property can be declared as const also. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r disable optional_qualifier@ identifier i; position p; @@ static struct vb2_ops i@p = { ... }; @ok@ identifier r.i; struct vb2_queue e; position p; @@ e.ops = &i@p; @bad@ position p != {r.p,ok.p}; identifier r.i; struct vb2_ops e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct vb2_ops i = { ... }; // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
This commit is contained in:
parent
6dca6cf072
commit
1bc177174b
|
@ -605,7 +605,7 @@ static void airspy_stop_streaming(struct vb2_queue *vq)
|
|||
mutex_unlock(&s->v4l2_lock);
|
||||
}
|
||||
|
||||
static struct vb2_ops airspy_vb2_ops = {
|
||||
static const struct vb2_ops airspy_vb2_ops = {
|
||||
.queue_setup = airspy_queue_setup,
|
||||
.buf_queue = airspy_buf_queue,
|
||||
.start_streaming = airspy_start_streaming,
|
||||
|
|
|
@ -928,7 +928,7 @@ void au0828_stop_vbi_streaming(struct vb2_queue *vq)
|
|||
del_timer_sync(&dev->vbi_timeout);
|
||||
}
|
||||
|
||||
static struct vb2_ops au0828_video_qops = {
|
||||
static const struct vb2_ops au0828_video_qops = {
|
||||
.queue_setup = queue_setup,
|
||||
.buf_prepare = buffer_prepare,
|
||||
.buf_queue = buffer_queue,
|
||||
|
|
|
@ -1204,7 +1204,7 @@ buffer_queue(struct vb2_buffer *vb)
|
|||
spin_unlock_irqrestore(&dev->slock, flags);
|
||||
}
|
||||
|
||||
static struct vb2_ops em28xx_video_qops = {
|
||||
static const struct vb2_ops em28xx_video_qops = {
|
||||
.queue_setup = queue_setup,
|
||||
.buf_prepare = buffer_prepare,
|
||||
.buf_queue = buffer_queue,
|
||||
|
|
|
@ -477,7 +477,7 @@ static void go7007_stop_streaming(struct vb2_queue *q)
|
|||
go7007_write_addr(go, 0x3c82, 0x000d);
|
||||
}
|
||||
|
||||
static struct vb2_ops go7007_video_qops = {
|
||||
static const struct vb2_ops go7007_video_qops = {
|
||||
.queue_setup = go7007_queue_setup,
|
||||
.buf_queue = go7007_buf_queue,
|
||||
.buf_prepare = go7007_buf_prepare,
|
||||
|
|
|
@ -891,7 +891,7 @@ static void hackrf_stop_streaming(struct vb2_queue *vq)
|
|||
mutex_unlock(&dev->v4l2_lock);
|
||||
}
|
||||
|
||||
static struct vb2_ops hackrf_vb2_ops = {
|
||||
static const struct vb2_ops hackrf_vb2_ops = {
|
||||
.queue_setup = hackrf_queue_setup,
|
||||
.buf_queue = hackrf_buf_queue,
|
||||
.start_streaming = hackrf_start_streaming,
|
||||
|
|
|
@ -897,7 +897,7 @@ static void msi2500_stop_streaming(struct vb2_queue *vq)
|
|||
mutex_unlock(&dev->v4l2_lock);
|
||||
}
|
||||
|
||||
static struct vb2_ops msi2500_vb2_ops = {
|
||||
static const struct vb2_ops msi2500_vb2_ops = {
|
||||
.queue_setup = msi2500_queue_setup,
|
||||
.buf_queue = msi2500_buf_queue,
|
||||
.start_streaming = msi2500_start_streaming,
|
||||
|
|
|
@ -707,7 +707,7 @@ static void stop_streaming(struct vb2_queue *vq)
|
|||
mutex_unlock(&pdev->v4l2_lock);
|
||||
}
|
||||
|
||||
static struct vb2_ops pwc_vb_queue_ops = {
|
||||
static const struct vb2_ops pwc_vb_queue_ops = {
|
||||
.queue_setup = queue_setup,
|
||||
.buf_init = buffer_init,
|
||||
.buf_prepare = buffer_prepare,
|
||||
|
|
|
@ -717,7 +717,7 @@ static void buffer_queue(struct vb2_buffer *vb)
|
|||
static int start_streaming(struct vb2_queue *vq, unsigned int count);
|
||||
static void stop_streaming(struct vb2_queue *vq);
|
||||
|
||||
static struct vb2_ops s2255_video_qops = {
|
||||
static const struct vb2_ops s2255_video_qops = {
|
||||
.queue_setup = queue_setup,
|
||||
.buf_prepare = buffer_prepare,
|
||||
.buf_queue = buffer_queue,
|
||||
|
|
|
@ -742,7 +742,7 @@ static void stop_streaming(struct vb2_queue *vq)
|
|||
stk1160_stop_streaming(dev);
|
||||
}
|
||||
|
||||
static struct vb2_ops stk1160_video_qops = {
|
||||
static const struct vb2_ops stk1160_video_qops = {
|
||||
.queue_setup = queue_setup,
|
||||
.buf_queue = buffer_queue,
|
||||
.start_streaming = start_streaming,
|
||||
|
|
|
@ -689,7 +689,7 @@ static void usbtv_stop_streaming(struct vb2_queue *vq)
|
|||
usbtv_stop(usbtv);
|
||||
}
|
||||
|
||||
static struct vb2_ops usbtv_vb2_ops = {
|
||||
static const struct vb2_ops usbtv_vb2_ops = {
|
||||
.queue_setup = usbtv_queue_setup,
|
||||
.buf_queue = usbtv_buf_queue,
|
||||
.start_streaming = usbtv_start_streaming,
|
||||
|
|
|
@ -177,7 +177,7 @@ static void uvc_stop_streaming(struct vb2_queue *vq)
|
|||
spin_unlock_irqrestore(&queue->irqlock, flags);
|
||||
}
|
||||
|
||||
static struct vb2_ops uvc_queue_qops = {
|
||||
static const struct vb2_ops uvc_queue_qops = {
|
||||
.queue_setup = uvc_queue_setup,
|
||||
.buf_prepare = uvc_buffer_prepare,
|
||||
.buf_queue = uvc_buffer_queue,
|
||||
|
|
Loading…
Reference in New Issue