KVM: x86: allow setting identity map addr with no vcpus only

Changing it afterwards doesn't make too much sense and will only result
in inconsistencies.

Reviewed-by: Radim Krčmář <rkrcmar@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
This commit is contained in:
David Hildenbrand 2017-08-24 20:51:36 +02:00 committed by Paolo Bonzini
parent 726b99c4f7
commit 1af1ac910b
2 changed files with 8 additions and 1 deletions

View File

@ -1131,6 +1131,7 @@ This ioctl is required on Intel-based hosts. This is needed on Intel hardware
because of a quirk in the virtualization implementation (see the internals because of a quirk in the virtualization implementation (see the internals
documentation when it pops into existence). documentation when it pops into existence).
Fails if any VCPU has already been created.
4.41 KVM_SET_BOOT_CPU_ID 4.41 KVM_SET_BOOT_CPU_ID

View File

@ -4034,10 +4034,16 @@ long kvm_arch_vm_ioctl(struct file *filp,
case KVM_SET_IDENTITY_MAP_ADDR: { case KVM_SET_IDENTITY_MAP_ADDR: {
u64 ident_addr; u64 ident_addr;
mutex_lock(&kvm->lock);
r = -EINVAL;
if (kvm->created_vcpus)
goto set_identity_unlock;
r = -EFAULT; r = -EFAULT;
if (copy_from_user(&ident_addr, argp, sizeof ident_addr)) if (copy_from_user(&ident_addr, argp, sizeof ident_addr))
goto out; goto set_identity_unlock;
r = kvm_vm_ioctl_set_identity_map_addr(kvm, ident_addr); r = kvm_vm_ioctl_set_identity_map_addr(kvm, ident_addr);
set_identity_unlock:
mutex_unlock(&kvm->lock);
break; break;
} }
case KVM_SET_NR_MMU_PAGES: case KVM_SET_NR_MMU_PAGES: