hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Memory leak in tpm_ascii_bios_measurements_open() 

Coverity found a memory leak in tpm_ascii_bios_measurements_open().

If "read_log(log)" fails, then we may leak 'log' and
'log->bios_event_log'.

Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Cc: Seiji Munetoh <munetoh@jp.ibm.com>
Cc: Stefan Berger <stefanb@us.ibm.com>
Cc: Reiner Sailer <sailer@watson.ibm.com>
Cc: Kylene Hall <kjhall@us.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Jesper Juhl 2007-07-20 00:31:48 -07:00 committed by Linus Torvalds
parent 22982a5687
commit 178554ae75
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/char/tpm/tpm_bios.c
View File

@ -427,7 +427,7 @@ static int tpm_ascii_bios_measurements_open(struct inode *inode,
return -ENOMEM; return -ENOMEM;
if ((err = read_log(log))) if ((err = read_log(log)))
return err; goto out_free;
/* now register seq file */ /* now register seq file */
err = seq_open(file, &tpm_ascii_b_measurments_seqops); err = seq_open(file, &tpm_ascii_b_measurments_seqops);
@ -435,10 +435,15 @@ static int tpm_ascii_bios_measurements_open(struct inode *inode,
seq = file->private_data; seq = file->private_data;
seq->private = log; seq->private = log;
} else { } else {
kfree(log->bios_event_log); goto out_free;
kfree(log);
} }
out:
return err; return err;
out_free:
kfree(log->bios_event_log);
kfree(log);
goto out;
} }
const struct file_operations tpm_ascii_bios_measurements_ops = { const struct file_operations tpm_ascii_bios_measurements_ops = {