net: sched: factorize code (qdisc_drop())

Use qdisc_drop() helper where possible.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Eric Dumazet 2012-05-04 04:37:21 +00:00 committed by David S. Miller
parent 041441d0f0
commit 1704575519
4 changed files with 6 additions and 13 deletions

View File

@ -332,15 +332,13 @@ static int choke_enqueue(struct sk_buff *skb, struct Qdisc *sch)
}
q->stats.pdrop++;
sch->qstats.drops++;
kfree_skb(skb);
return NET_XMIT_DROP;
return qdisc_drop(skb, sch);
congestion_drop:
congestion_drop:
qdisc_drop(skb, sch);
return NET_XMIT_CN;
other_drop:
other_drop:
if (ret & __NET_XMIT_BYPASS)
sch->qstats.drops++;
kfree_skb(skb);

View File

@ -265,8 +265,7 @@ static int dsmark_enqueue(struct sk_buff *skb, struct Qdisc *sch)
return NET_XMIT_SUCCESS;
drop:
kfree_skb(skb);
sch->qstats.drops++;
qdisc_drop(skb, sch);
return NET_XMIT_SUCCESS | __NET_XMIT_BYPASS;
}

View File

@ -558,9 +558,7 @@ static int htb_enqueue(struct sk_buff *skb, struct Qdisc *sch)
__skb_queue_tail(&q->direct_queue, skb);
q->direct_pkts++;
} else {
kfree_skb(skb);
sch->qstats.drops++;
return NET_XMIT_DROP;
return qdisc_drop(skb, sch);
}
#ifdef CONFIG_NET_CLS_ACT
} else if (!cl) {

View File

@ -88,9 +88,7 @@ teql_enqueue(struct sk_buff *skb, struct Qdisc *sch)
return NET_XMIT_SUCCESS;
}
kfree_skb(skb);
sch->qstats.drops++;
return NET_XMIT_DROP;
return qdisc_drop(skb, sch);
}
static struct sk_buff *