tools build: Fix Makefile(s) to properly invoke tools build
Several fixes were needed to allow following builds: $ make tools/tmon $ make -C <kernelsrc> tools/perf $ make -C <kernelsrc>/tools perf - some of the tools (perf) use same make variables as in kernel build, unsetting srctree and objtree - using original $(O) for O variable - perf build does not follow the descend function setup invoking it via it's own make rule I tried the rest of the tools/Makefile targets and they seem to work now. Reported-by: Brian Norris <computersforpeace@gmail.com> Signed-off-by: Jiri Olsa <jolsa@kernel.org> Cc: Borislav Petkov <bp@suse.de> Cc: Brian Norris <computersforpeace@gmail.com> Cc: David Ahern <dsahern@gmail.com> Cc: David Howells <dhowells@redhat.com> Cc: Michal Marek <mmarek@suse.cz> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Sam Ravnborg <sam@ravnborg.org> Cc: linux-kbuild@vger.kernel.org Link: http://lkml.kernel.org/r/1429389280-18720-3-git-send-email-jolsa@kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
parent
379a9a28a1
commit
16671c1e1c
5
Makefile
5
Makefile
|
@ -214,7 +214,6 @@ VPATH := $(srctree)$(if $(KBUILD_EXTMOD),:$(KBUILD_EXTMOD))
|
||||||
|
|
||||||
export srctree objtree VPATH
|
export srctree objtree VPATH
|
||||||
|
|
||||||
|
|
||||||
# SUBARCH tells the usermode build what the underlying arch is. That is set
|
# SUBARCH tells the usermode build what the underlying arch is. That is set
|
||||||
# first, and if a usermode build is happening, the "ARCH=um" on the command
|
# first, and if a usermode build is happening, the "ARCH=um" on the command
|
||||||
# line overrides the setting of ARCH below. If a native build is happening,
|
# line overrides the setting of ARCH below. If a native build is happening,
|
||||||
|
@ -1504,11 +1503,11 @@ image_name:
|
||||||
# Clear a bunch of variables before executing the submake
|
# Clear a bunch of variables before executing the submake
|
||||||
tools/: FORCE
|
tools/: FORCE
|
||||||
$(Q)mkdir -p $(objtree)/tools
|
$(Q)mkdir -p $(objtree)/tools
|
||||||
$(Q)$(MAKE) LDFLAGS= MAKEFLAGS="$(filter --j% -j,$(MAKEFLAGS))" O=$(objtree) subdir=tools -C $(src)/tools/
|
$(Q)$(MAKE) LDFLAGS= MAKEFLAGS="$(filter --j% -j,$(MAKEFLAGS))" O=$(O) subdir=tools -C $(src)/tools/
|
||||||
|
|
||||||
tools/%: FORCE
|
tools/%: FORCE
|
||||||
$(Q)mkdir -p $(objtree)/tools
|
$(Q)mkdir -p $(objtree)/tools
|
||||||
$(Q)$(MAKE) LDFLAGS= MAKEFLAGS="$(filter --j% -j,$(MAKEFLAGS))" O=$(objtree) subdir=tools -C $(src)/tools/ $*
|
$(Q)$(MAKE) LDFLAGS= MAKEFLAGS="$(filter --j% -j,$(MAKEFLAGS))" O=$(O) subdir=tools -C $(src)/tools/ $*
|
||||||
|
|
||||||
# Single targets
|
# Single targets
|
||||||
# ---------------------------------------------------------------------------
|
# ---------------------------------------------------------------------------
|
||||||
|
|
|
@ -1,3 +1,8 @@
|
||||||
|
# Some of the tools (perf) use same make variables
|
||||||
|
# as in kernel build.
|
||||||
|
export srctree=
|
||||||
|
export objtree=
|
||||||
|
|
||||||
include scripts/Makefile.include
|
include scripts/Makefile.include
|
||||||
|
|
||||||
help:
|
help:
|
||||||
|
@ -50,8 +55,13 @@ liblockdep: FORCE
|
||||||
libapi: FORCE
|
libapi: FORCE
|
||||||
$(call descend,lib/api)
|
$(call descend,lib/api)
|
||||||
|
|
||||||
|
# The perf build does not follow the descend function setup,
|
||||||
|
# invoking it via it's own make rule.
|
||||||
|
PERF_O = $(if $(O),$(O)/tools/perf,)
|
||||||
|
|
||||||
perf: FORCE
|
perf: FORCE
|
||||||
$(call descend,$@)
|
$(Q)mkdir -p $(PERF_O) .
|
||||||
|
$(Q)$(MAKE) --no-print-directory -C perf O=$(PERF_O) subdir=
|
||||||
|
|
||||||
selftests: FORCE
|
selftests: FORCE
|
||||||
$(call descend,testing/$@)
|
$(call descend,testing/$@)
|
||||||
|
|
Loading…
Reference in New Issue