f2fs: prevent checkpoint during roll-forward
Any checkpoint should not be done during the core roll-forward procedure. Especially, it includes error cases too. Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
This commit is contained in:
parent
b3fe0a0da2
commit
14f4e69085
|
@ -459,6 +459,9 @@ int recover_fsync_data(struct f2fs_sb_info *sbi)
|
||||||
/* step #1: find fsynced inode numbers */
|
/* step #1: find fsynced inode numbers */
|
||||||
sbi->por_doing = true;
|
sbi->por_doing = true;
|
||||||
|
|
||||||
|
/* prevent checkpoint */
|
||||||
|
mutex_lock(&sbi->cp_mutex);
|
||||||
|
|
||||||
blkaddr = NEXT_FREE_BLKADDR(sbi, curseg);
|
blkaddr = NEXT_FREE_BLKADDR(sbi, curseg);
|
||||||
|
|
||||||
err = find_fsync_dnodes(sbi, &inode_list);
|
err = find_fsync_dnodes(sbi, &inode_list);
|
||||||
|
@ -490,8 +493,13 @@ out:
|
||||||
/* Flush all the NAT/SIT pages */
|
/* Flush all the NAT/SIT pages */
|
||||||
while (get_pages(sbi, F2FS_DIRTY_META))
|
while (get_pages(sbi, F2FS_DIRTY_META))
|
||||||
sync_meta_pages(sbi, META, LONG_MAX);
|
sync_meta_pages(sbi, META, LONG_MAX);
|
||||||
|
set_ckpt_flags(sbi->ckpt, CP_ERROR_FLAG);
|
||||||
|
mutex_unlock(&sbi->cp_mutex);
|
||||||
} else if (need_writecp) {
|
} else if (need_writecp) {
|
||||||
|
mutex_unlock(&sbi->cp_mutex);
|
||||||
write_checkpoint(sbi, false);
|
write_checkpoint(sbi, false);
|
||||||
|
} else {
|
||||||
|
mutex_unlock(&sbi->cp_mutex);
|
||||||
}
|
}
|
||||||
return err;
|
return err;
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue