Subject: lockdep: include all lock classes in all_lock_classes
Add each lock class to the all_lock_classes list when it is first registered. Previously, lock classes were added to all_lock_classes when the lock class was first used. Since one of the uses of the list is to find unused locks, this didn't work well. Signed-off-by: Dale Farnsworth <dale@farnsworth.org> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl> Signed-off-by: Ingo Molnar <mingo@elte.hu>
This commit is contained in:
parent
bdb9441e9c
commit
1481197b50
|
@ -779,6 +779,10 @@ register_lock_class(struct lockdep_map *lock, unsigned int subclass, int force)
|
||||||
* parallel walking of the hash-list safe:
|
* parallel walking of the hash-list safe:
|
||||||
*/
|
*/
|
||||||
list_add_tail_rcu(&class->hash_entry, hash_head);
|
list_add_tail_rcu(&class->hash_entry, hash_head);
|
||||||
|
/*
|
||||||
|
* Add it to the global list of classes:
|
||||||
|
*/
|
||||||
|
list_add_tail_rcu(&class->lock_entry, &all_lock_classes);
|
||||||
|
|
||||||
if (verbose(class)) {
|
if (verbose(class)) {
|
||||||
graph_unlock();
|
graph_unlock();
|
||||||
|
@ -2282,10 +2286,6 @@ static int mark_lock(struct task_struct *curr, struct held_lock *this,
|
||||||
return 0;
|
return 0;
|
||||||
break;
|
break;
|
||||||
case LOCK_USED:
|
case LOCK_USED:
|
||||||
/*
|
|
||||||
* Add it to the global list of classes:
|
|
||||||
*/
|
|
||||||
list_add_tail_rcu(&this->class->lock_entry, &all_lock_classes);
|
|
||||||
debug_atomic_dec(&nr_unused_locks);
|
debug_atomic_dec(&nr_unused_locks);
|
||||||
break;
|
break;
|
||||||
default:
|
default:
|
||||||
|
|
Loading…
Reference in New Issue