hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

gpio: Remove VLA from xra1403 driver 

The new challenge is to remove VLAs from the kernel
(see https://lkml.org/lkml/2018/3/7/621)

This patch replaces a VLA with an appropriate call to kmalloc_array.

Signed-off-by: Laura Abbott <labbott@redhat.com>
Reviewed-by: Nandor Han <nandor.han@ge.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Laura Abbott 2018-03-09 16:10:20 -08:00 committed by Linus Walleij
parent 48da181dac
commit 13b5319e92
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/gpio/gpio-xra1403.c
View File

@ -126,11 +126,16 @@ static void xra1403_dbg_show(struct seq_file *s, struct gpio_chip *chip)
{ {
int reg; int reg;
struct xra1403 *xra = gpiochip_get_data(chip); struct xra1403 *xra = gpiochip_get_data(chip);
int value[xra1403_regmap_cfg.max_register]; int *value;
int i; int i;
unsigned int gcr; unsigned int gcr;
unsigned int gsr; unsigned int gsr;
value = kmalloc_array(xra1403_regmap_cfg.max_register, sizeof(*value),
GFP_KERNEL);
if (!value)
return;
seq_puts(s, "xra reg:"); seq_puts(s, "xra reg:");
for (reg = 0; reg <= xra1403_regmap_cfg.max_register; reg++) for (reg = 0; reg <= xra1403_regmap_cfg.max_register; reg++)
seq_printf(s, " %2.2x", reg); seq_printf(s, " %2.2x", reg);
@ -154,6 +159,7 @@ static void xra1403_dbg_show(struct seq_file *s, struct gpio_chip *chip)
(gcr & BIT(i)) ? "in" : "out", (gcr & BIT(i)) ? "in" : "out",
(gsr & BIT(i)) ? "hi" : "lo"); (gsr & BIT(i)) ? "hi" : "lo");
} }
kfree(value);
} }
#else #else
#define xra1403_dbg_show NULL #define xra1403_dbg_show NULL