hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

wireguard: queueing: cleanup ptr_ring in error path of packet_queue_init 

Prior, if the alloc_percpu of packet_percpu_multicore_worker_alloc
failed, the previously allocated ptr_ring wouldn't be freed. This commit
adds the missing call to ptr_ring_cleanup in the error case.

Reported-by: Sultan Alsawaf <sultan@kerneltoast.com>
Fixes: e7096c131e ("net: WireGuard secure network tunnel")
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Jason A. Donenfeld 2020-04-29 14:59:21 -06:00 committed by David S. Miller
parent d6833e4278
commit 130c586061
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/wireguard/queueing.c
View File

@ -35,8 +35,10 @@ int wg_packet_queue_init(struct crypt_queue *queue, work_func_t function,
if (multicore) { if (multicore) {
queue->worker = wg_packet_percpu_multicore_worker_alloc( queue->worker = wg_packet_percpu_multicore_worker_alloc(
function, queue); function, queue);
if (!queue->worker) if (!queue->worker) {
ptr_ring_cleanup(&queue->ring, NULL);
return -ENOMEM; return -ENOMEM;
}
} else { } else {
INIT_WORK(&queue->work, function); INIT_WORK(&queue->work, function);
} }