btrfs: introduce conditional wakeup helpers
Add convenience wrappers for the waitqueue management that involves memory barriers to prevent deadlocks. The helpers will let us remove barriers and the necessary comments in several places. Reviewed-by: Nikolay Borisov <nborisov@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
parent
ff3d27a048
commit
110a21feed
|
@ -3755,4 +3755,26 @@ static inline int btrfs_is_testing(struct btrfs_fs_info *fs_info)
|
|||
return 0;
|
||||
}
|
||||
|
||||
static inline void cond_wake_up(struct wait_queue_head *wq)
|
||||
{
|
||||
/*
|
||||
* This implies a full smp_mb barrier, see comments for
|
||||
* waitqueue_active why.
|
||||
*/
|
||||
if (wq_has_sleeper(wq))
|
||||
wake_up(wq);
|
||||
}
|
||||
|
||||
static inline void cond_wake_up_nomb(struct wait_queue_head *wq)
|
||||
{
|
||||
/*
|
||||
* Special case for conditional wakeup where the barrier required for
|
||||
* waitqueue_active is implied by some of the preceding code. Eg. one
|
||||
* of such atomic operations (atomic_dec_and_return, ...), or a
|
||||
* unlock/lock sequence, etc.
|
||||
*/
|
||||
if (waitqueue_active(wq))
|
||||
wake_up(wq);
|
||||
}
|
||||
|
||||
#endif
|
||||
|
|
Loading…
Reference in New Issue