hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

OMAP3: serial: Use dev_* macros instead of printk 

As we have a struct device populated at the time we are
printing the errors, using dev_* macros makes more sense,
as could give a better idea where the error/warning came from.

Signed-off-by: Sergio Aguirre <saaguirre@ti.com>
This commit is contained in:
Sergio Aguirre 2010-03-09 13:22:14 -06:00
parent e88d556dc5
commit 10c805eb4f
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
arch/arm/mach-omap2/serial.c
View File

@ -550,7 +550,7 @@ static ssize_t sleep_timeout_store(struct device *dev,
unsigned int value; unsigned int value;
if (sscanf(buf, "%u", &value) != 1) { if (sscanf(buf, "%u", &value) != 1) {
printk(KERN_ERR "sleep_timeout_store: Invalid value\n"); dev_err(dev, "sleep_timeout_store: Invalid value\n");
return -EINVAL; return -EINVAL;
} }
@ -666,8 +666,8 @@ void __init omap_serial_early_init(void)
/* Don't map zero-based physical address */ /* Don't map zero-based physical address */
if (p->mapbase == 0) { if (p->mapbase == 0) {
printk(KERN_WARNING "omap serial: No physical address" dev_warn(dev, "no physical address for uart#%d,"
" for uart#%d, so skipping early_init...\n", i); " so skipping early_init...\n", i);
continue; continue;
} }
/* /*
@ -676,21 +676,21 @@ void __init omap_serial_early_init(void)
*/ */
p->membase = ioremap(p->mapbase, SZ_8K); p->membase = ioremap(p->mapbase, SZ_8K);
if (!p->membase) { if (!p->membase) {
printk(KERN_ERR "ioremap failed for uart%i\n", i + 1); dev_err(dev, "ioremap failed for uart%i\n", i + 1);
continue; continue;
} }
sprintf(name, "uart%d_ick", i + 1); sprintf(name, "uart%d_ick", i + 1);
uart->ick = clk_get(NULL, name); uart->ick = clk_get(NULL, name);
if (IS_ERR(uart->ick)) { if (IS_ERR(uart->ick)) {
printk(KERN_ERR "Could not get uart%d_ick\n", i + 1); dev_err(dev, "Could not get uart%d_ick\n", i + 1);
uart->ick = NULL; uart->ick = NULL;
} }
sprintf(name, "uart%d_fck", i+1); sprintf(name, "uart%d_fck", i+1);
uart->fck = clk_get(NULL, name); uart->fck = clk_get(NULL, name);
if (IS_ERR(uart->fck)) { if (IS_ERR(uart->fck)) {
printk(KERN_ERR "Could not get uart%d_fck\n", i + 1); dev_err(dev, "Could not get uart%d_fck\n", i + 1);
uart->fck = NULL; uart->fck = NULL;
} }